Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

query: Disable downsampling by default. #407

Merged
merged 2 commits into from
Jul 5, 2018
Merged

query: Disable downsampling by default. #407

merged 2 commits into from
Jul 5, 2018

Conversation

bwplotka
Copy link
Member

@bwplotka bwplotka commented Jul 4, 2018

(Details #376)

Signed-off-by: Bartek Plotka [email protected]

@bwplotka bwplotka force-pushed the downsampling branch 2 times, most recently from 7dee44e to cf269a5 Compare July 5, 2018 08:29
@bwplotka bwplotka changed the title query: Disable downsampling by default until it will came out of experimental phase. query: Disable downsampling by default. Jul 5, 2018
@domgreen
Copy link
Contributor

domgreen commented Jul 5, 2018

Would it not be better to pass in a flag to explicitly turn it on rather than forcing a recompile / upgrade to work with it?
Or are we saying its still early in the development phase so don't use for the moment?

(Details #376)

Signed-off-by: Bartek Plotka <[email protected]>
@bwplotka
Copy link
Member Author

bwplotka commented Jul 5, 2018

@domgreen Good point, changed it to flag.

Copy link
Contributor

@domgreen domgreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - providing we have tested that maxSourceResolution is fine to be 0. 👍

@bwplotka bwplotka merged commit 9043578 into master Jul 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants