Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Updated design document page #4076

Merged
merged 3 commits into from
Apr 21, 2021
Merged

docs: Updated design document page #4076

merged 3 commits into from
Apr 21, 2021

Conversation

iamrajiv
Copy link
Contributor

@iamrajiv iamrajiv commented Apr 17, 2021

No description provided.

bwplotka
bwplotka previously approved these changes Apr 19, 2021
Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Some comments otherwise LGTM (:

@Namanl2001
Copy link
Contributor

@iamrajiv You need to sign off each of your commits to pass the DCO check. Thanks

iamrajiv and others added 3 commits April 20, 2021 07:15
Signed-off-by: Rajiv Ranjan Singh <[email protected]>
Co-authored-by: Bartlomiej Plotka <[email protected]>
Signed-off-by: Rajiv Ranjan Singh <[email protected]>
Signed-off-by: Rajiv Ranjan Singh <[email protected]>
@kakkoyun kakkoyun changed the title Updated design doc docs: Updated design document page Apr 21, 2021
Copy link
Member

@kakkoyun kakkoyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@kakkoyun kakkoyun merged commit 15042c2 into thanos-io:main Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants