Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

query: Added tests for compatiblity for old components without InfoAPI. #4645

Merged
merged 1 commit into from
Sep 8, 2021

Conversation

bwplotka
Copy link
Member

@bwplotka bwplotka commented Sep 7, 2021

Signed-off-by: Bartlomiej Plotka [email protected]

@bwplotka
Copy link
Member Author

bwplotka commented Sep 7, 2021

Blocks release, if we can repro.

@bwplotka bwplotka mentioned this pull request Sep 7, 2021
@bwplotka bwplotka force-pushed the regr-endp branch 4 times, most recently from f2da3cc to df08b9c Compare September 7, 2021 16:01
@bwplotka bwplotka requested a review from yeya24 September 7, 2021 16:01
@bwplotka bwplotka changed the title query: Added tests and compatiblity for old components without InfoAPI. query: Added tests for compatiblity for old components without InfoAPI. Sep 7, 2021
@bwplotka
Copy link
Member Author

bwplotka commented Sep 7, 2021

Added tests that confirms... all is good XD

@bwplotka
Copy link
Member Author

bwplotka commented Sep 7, 2021

Just extra tests if we want them to ensure compatibility (:

Copy link
Member

@GiedriusS GiedriusS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yeya24 yeya24 merged commit 81aef72 into main Sep 8, 2021
@bwplotka bwplotka deleted the regr-endp branch September 8, 2021 11:10
someshkoli pushed a commit to someshkoli/thanos that referenced this pull request Nov 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants