-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
COS: Change to official COS object store SDK. #4654
Conversation
ac91ca0
to
cb5550d
Compare
How to add auto-tested on CI for COS ? I am glad to add it if possible, like GCS. https://github.com/thanos-io/thanos/blob/main/docs/storage.md#supported-clients. thanks. |
cb5550d
to
ac11fc9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pr LGTM.
@hanjm As you are working at Tencent and use COS with Thanos in production, are you willing to help maintain Tencent COS client for Thanos?
cc @jojohappy
Fix objstore e2e test invalid test bucket name. Fix setRange when off>0. Signed-off-by: hanjm <[email protected]>
ac11fc9
to
9e5da6b
Compare
Yes, I am willing to help maintain Tencent COS client for Thanos. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
SGTM. Please open another pr to update the obj store maintainer docs, thank you. |
Fix objstore e2e test invalid test bucket name. Fix setRange when off>0. Signed-off-by: hanjm <[email protected]>
Change to official COS object store SDK.
Fix objstore e2e test invalid test bucket name.
Fix setRange when off>0.
Signed-off-by: hanjm [email protected]
Hi all,
The COS objstore support is implement via
github.com/mozillazg/go-cos
at 2019 year,the
mozillazg/go-cos
is unfficial and not actively update now, it's latest tag version date is 2019-09-18.the official sdk
github.com/tencentyun/cos-go-sdk-v5
which based onmozillazg/go-cos
is keeping actively update, the latest tag date is2021-09-07
.It should be change to official SDK to get more support. I fix testing bucket name bug and setRange bug, then it has passed the e2e objectore test.
thanks to @jojohappy and mozillazg/go-cos author.
Changes
Verification
run objstore e2e test: