-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Receive + Prometheus Agent tutorial. #4817
Conversation
See preview here: https://katacoda.com/bwplotka/courses/thanos/4-receiver-agent |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM on the Prometheus Agent details!
Also updated tutorial 3. Signed-off-by: Bartlomiej Plotka <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job! 🥇 I think the overall task and steps are clearly described, I just have few nits.
Co-authored-by: Matej Gera <[email protected]>
Signed-off-by: Bartlomiej Plotka <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM % notes
-v /root/prom-batmobile-data:/prometheus \ | ||
-u root \ | ||
--name prom-agent-batmobile \ | ||
quay.io/bwplotka/prometheus:agent1 \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a more official looking image we can use? 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will be when Agent is released (:
Co-authored-by: Ian Billett <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you all for amazing review!
-v /root/prom-batmobile-data:/prometheus \ | ||
-u root \ | ||
--name prom-agent-batmobile \ | ||
quay.io/bwplotka/prometheus:agent1 \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will be when Agent is released (:
Signed-off-by: Bartlomiej Plotka <[email protected]>
Signed-off-by: Bartlomiej Plotka <[email protected]>
Signed-off-by: Bartlomiej Plotka <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Also updated tutorial 3.
Signed-off-by: Bartlomiej Plotka [email protected]