Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Receive + Prometheus Agent tutorial. #4817

Merged
merged 7 commits into from
Nov 3, 2021
Merged

Added Receive + Prometheus Agent tutorial. #4817

merged 7 commits into from
Nov 3, 2021

Conversation

bwplotka
Copy link
Member

Also updated tutorial 3.

Signed-off-by: Bartlomiej Plotka [email protected]

@bwplotka bwplotka requested a review from bill3tt October 29, 2021 18:20
@bwplotka
Copy link
Member Author

@bwplotka
Copy link
Member Author

cc @spaparaju @rfratto

rfratto
rfratto previously approved these changes Oct 29, 2021
Copy link

@rfratto rfratto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on the Prometheus Agent details!

tutorials/katacoda/thanos/4-receiver-agent/index.json Outdated Show resolved Hide resolved
tutorials/katacoda/thanos/4-receiver-agent/intro.md Outdated Show resolved Hide resolved
Also updated tutorial 3.

Signed-off-by: Bartlomiej Plotka <[email protected]>
matej-g
matej-g previously approved these changes Oct 31, 2021
Copy link
Collaborator

@matej-g matej-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! 🥇 I think the overall task and steps are clearly described, I just have few nits.

tutorials/katacoda/thanos/4-receiver-agent/intro.md Outdated Show resolved Hide resolved
tutorials/katacoda/thanos/4-receiver-agent/intro.md Outdated Show resolved Hide resolved
tutorials/katacoda/thanos/4-receiver-agent/intro.md Outdated Show resolved Hide resolved
tutorials/katacoda/thanos/4-receiver-agent/step1.md Outdated Show resolved Hide resolved
tutorials/katacoda/thanos/4-receiver-agent/step2.md Outdated Show resolved Hide resolved
bwplotka and others added 2 commits November 1, 2021 16:35
Signed-off-by: Bartlomiej Plotka <[email protected]>
bill3tt
bill3tt previously approved these changes Nov 1, 2021
Copy link
Contributor

@bill3tt bill3tt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % notes

tutorials/katacoda/thanos/4-receiver-agent/intro.md Outdated Show resolved Hide resolved
tutorials/katacoda/thanos/4-receiver-agent/step1.md Outdated Show resolved Hide resolved
tutorials/katacoda/thanos/4-receiver-agent/step1.md Outdated Show resolved Hide resolved
tutorials/katacoda/thanos/4-receiver-agent/step1.md Outdated Show resolved Hide resolved
tutorials/katacoda/thanos/4-receiver-agent/step1.md Outdated Show resolved Hide resolved
tutorials/katacoda/thanos/4-receiver-agent/step1.md Outdated Show resolved Hide resolved
tutorials/katacoda/thanos/4-receiver-agent/step2.md Outdated Show resolved Hide resolved
-v /root/prom-batmobile-data:/prometheus \
-u root \
--name prom-agent-batmobile \
quay.io/bwplotka/prometheus:agent1 \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a more official looking image we can use? 😅

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will be when Agent is released (:

Copy link
Member Author

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you all for amazing review!

-v /root/prom-batmobile-data:/prometheus \
-u root \
--name prom-agent-batmobile \
quay.io/bwplotka/prometheus:agent1 \
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will be when Agent is released (:

Signed-off-by: Bartlomiej Plotka <[email protected]>
Signed-off-by: Bartlomiej Plotka <[email protected]>
Signed-off-by: Bartlomiej Plotka <[email protected]>
Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bwplotka bwplotka merged commit 885b3bb into main Nov 3, 2021
@bwplotka bwplotka deleted the agent branch November 3, 2021 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants