Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated agent tutorial with important meme and beta tag. #4834

Merged
merged 2 commits into from
Nov 16, 2021
Merged

Updated agent tutorial with important meme and beta tag. #4834

merged 2 commits into from
Nov 16, 2021

Conversation

bwplotka
Copy link
Member

@bwplotka bwplotka commented Nov 5, 2021

image

Signed-off-by: Bartlomiej Plotka [email protected]

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Verification

@bwplotka bwplotka requested a review from bill3tt November 5, 2021 16:06
GiedriusS
GiedriusS reviewed Nov 10, 2021
View reviewed changes
Copy link
Member

@GiedriusS GiedriusS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a typo: it should be "running", not "runnig" 😄

@bwplotka
Copy link
Member Author

Thx! I am waiting for beta tag to be available today.

@bwplotka
Moved to beta.
8a39e3c 
Signed-off-by: Bartlomiej Plotka <[email protected]>
@bwplotka bwplotka marked this pull request as ready for review November 16, 2021 15:52
moadz
moadz approved these changes Nov 16, 2021
View reviewed changes
Copy link
Contributor

@moadz moadz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

matej-g
matej-g approved these changes Nov 16, 2021
View reviewed changes
Copy link
Collaborator

@matej-g matej-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So glad this important meme finally lands in the code base 🦇

@bwplotka bwplotka merged commit b0b853b into main Nov 16, 2021
@bwplotka bwplotka deleted the agent2 branch November 16, 2021 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GiedriusS GiedriusS GiedriusS left review comments

@moadz moadz moadz approved these changes

@matej-g matej-g matej-g approved these changes

@bill3tt bill3tt Awaiting requested review from bill3tt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bwplotka @GiedriusS @matej-g @moadz