Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod: Fix invalid reference to github.com/efficientgo/tools/core #4860

Merged
merged 1 commit into from
Nov 12, 2021

Conversation

matej-g
Copy link
Collaborator

@matej-g matej-g commented Nov 12, 2021

Signed-off-by: Matej Gera [email protected]

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

For some reason, the go.mod for github.com/efficientgo/tools/core points to an invalid git commit (it does not exist on any branch), which causes error:

thanos ❯ go get github.com/efficientgo/tools/core@421d0828c9a6                                                       
go get: github.com/efficientgo/tools/core@421d0828c9a6: invalid version: unknown revision 421d0828c9a6

Resolves #4806.

Verification

Go get works for

Signed-off-by: Matej Gera <[email protected]>
Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yeya24 yeya24 enabled auto-merge (squash) November 12, 2021 17:18
@yeya24 yeya24 merged commit 10dfacd into thanos-io:main Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken dependency on github.com/efficientgo/tools/core
2 participants