*: Implement info server for missing components #4886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds time range and label set methods to store to be able to populate info API responses Signed-off-by: Matej Gera <[email protected]>
…info - Makes some changes to info server options for better readability - Makes passing func optional - if no function passed, sets default empty response - Adjust existing components to fit adjusted info server options Signed-off-by: Matej Gera <[email protected]>
Signed-off-by: Matej Gera <[email protected]>
- Rely on info API response since all components in latest version implement it now - Simplify, remove an unnecessary interface and min/max time const Signed-off-by: Matej Gera <[email protected]>
…issing-components
- Simplify the functional option - remove interface - Better documentation Signed-off-by: Matej Gera <[email protected]>
|
Ran tests locally and seems like everything works as expected |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR is the continuation of the series of PRs to resolve the issue #2600 implementing the endpoints proposal.
The changes include:
Verification
Tests have been adjusted and passed locally. Manual test has been executed as well.