add NewBucketWithConfig for cos objstore #5076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Add the DCO please and we can merge this. |
Signed-off-by: nickzhwang <[email protected]>
Nicholaswang
force-pushed
the
optimize_cos_setup
branch
from
012451c to
f98d1b1
Compare
DCO added |
GiedriusS
approved these changes
Jan 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change is not relevant to the end-user.
Changes
add NewBucketWithConfig func for cos.
Note
I am importing objstore/cos package from thanos in other projects. Hoping to use NewBucketWithConfig as in s3 package rather than NewBucket() which only support byte slice parameter.