docs - Update kms encryption context guidance #5088
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 20, 2022 17:53
…ield Signed-off-by: Alex Vest <[email protected]>
Signed-off-by: Alex Vest <[email protected]>
|
I'm unsure as to whether I should add a changelog entry for this |
|
#5089 would remove the need for this PR. |
|
@avestuk - As per your comment, can this be closed? :) |
|
@wiardvanrij Sorry I completely forgot about this. Yes it can be closed and I'll do so now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Updated documentation for S3 SSE-KMS, after reporting them in #4245 - the change serves to avoid anybody having these issues in the future.
Verification
I ran make check-docs and the second commit contains the changes that the automation made that were not directly related to my change.