fix: changing description to not include rule groups #5105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matej-g
reviewed
Feb 10, 2022
… not include rule groups Signed-off-by: Prashant Balachandran <[email protected]>
prashbnair
force-pushed
the
alert-desc
branch
from
d3bc86c to
939a79b
Compare
matej-g
approved these changes
Feb 11, 2022
GiedriusS
approved these changes
Feb 11, 2022
Nicholaswang
pushed a commit
to Nicholaswang/thanos
that referenced
this pull request
Mar 6, 2022
… not include rule groups (thanos-io#5105) Signed-off-by: Prashant Balachandran <[email protected]> Signed-off-by: Nicholaswang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Prashant Balachandran [email protected]
Changing the description of the ThanosRuleNoEvaluationFor10Intervals alert rule to not include the number of rule groups as the expression was not evaluating the number of rule groups