fix tools bucket replicate: fix ignoring of deleted blocks #5162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FUSAKLA
commented
Feb 15, 2022
FUSAKLA
force-pushed
the
fus-fix-ignore-deleted
branch
2 times, most recently
from
9d1654b to
2dba037
Compare
Signed-off-by: Martin Chodur <[email protected]>
FUSAKLA
force-pushed
the
fus-fix-ignore-deleted
branch
from
2dba037 to
bffc17e
Compare
metalmatze
reviewed
Feb 15, 2022
Signed-off-by: Martin Chodur <[email protected]>
yeya24
reviewed
Feb 16, 2022
Signed-off-by: Martin Chodur <[email protected]>
Nicholaswang
pushed a commit
to Nicholaswang/thanos
that referenced
this pull request
Mar 6, 2022
…#5162) * fix tools bucket replicate: fix ignoring of deleted blocks Signed-off-by: Martin Chodur <[email protected]> * cr: style fixes Signed-off-by: Martin Chodur <[email protected]> * cr: optimize return and changelog white noise Signed-off-by: Martin Chodur <[email protected]> Signed-off-by: Nicholaswang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though ignoring of deleted blocks by the
tools bucket replicateadded in #5117 worksIt does not use the code base for filtering already prepared and that brings one additional drawback and that is it fails on reading block metadata if in process of deletion (which was also the case we were hitting)
The former implementation first read all meta files (which fails for the block that is being deleted) and only after checks for the deletion mark. The deletion mark has to be checked first, as the filtered meta fetcher does.
Sorry about that
Please, @GiedriusS and @wiardvanrij would you take a look one more time? 🙏