QueryFrontend: fixing bug on cortex cache for range query when using dynamic sharding #5688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…amic sharding Signed-off-by: Pedro Tanaka <[email protected]>
Signed-off-by: Pedro Tanaka <[email protected]>
Signed-off-by: Pedro Tanaka <[email protected]>
Signed-off-by: Pedro Tanaka <[email protected]>
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
Signed-off-by: Pedro Tanaka <[email protected]>
fpetkovski
reviewed
Sep 14, 2022
CHANGELOG.md
Outdated
| @@ -11,6 +11,7 @@ We use *breaking :warning:* to mark changes that are not backward compatible (re | |||
| ## Unreleased | |||
|
|
|||
| ### Fixed | |||
| - [#5688](https://github.com/thanos-io/thanos/pull/5688) Query Frontend: Fix bug with dynamic horizontal sharding parameters and cache key generator. | |||
There was a problem hiding this comment.
Since the feature is not yet released, I don't think we need a changelog entry.
fpetkovski
reviewed
Sep 14, 2022
Signed-off-by: Pedro Tanaka <[email protected]>
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
In #5617 I introduced new parameters for horizontal sharding, but I did not keep track of the usage of the
query-range.split-intervalparameter in other places. It was being used in QFE caching mechanism to generate cache keys and by using the new parameters a division by zero error would occur, this PR solves this problem.Verification
Created e2e test to reproduce the error I saw on my staging environment.