Compact: update "accept malformed index" flag to apply to downsampling #5689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marshall Lang <[email protected]>
Signed-off-by: Marshall Lang <[email protected]> Signed-off-by: Marshall Lang <[email protected]>
* Adding new parameter for more dynamic horizontal query sharding Signed-off-by: Pedro Tanaka <[email protected]> * Update docs for query FE Signed-off-by: Pedro Tanaka <[email protected]> * Adding new parameters and testing validation Signed-off-by: Pedro Tanaka <[email protected]> * Using new parameters instead of changing behavior for existing ones Signed-off-by: Pedro Tanaka <[email protected]> * Adding changelog entry for changes Signed-off-by: Pedro Tanaka <[email protected]> * Fixing problem on config validation and adding more test cases Signed-off-by: Pedro Tanaka <[email protected]> * Fixing linting Signed-off-by: Pedro Tanaka <[email protected]> * Change name of cli arguments and improve validation Signed-off-by: Pedro Tanaka <[email protected]> * Fixing changelog entry Signed-off-by: Pedro Tanaka <[email protected]> * Final touches on docs Signed-off-by: Pedro Tanaka <[email protected]> * Adding params names to changelog Signed-off-by: Pedro Tanaka <[email protected]> * Fixing CR comments Signed-off-by: Pedro Tanaka <[email protected]> * Adding additional check for minimal split interval Signed-off-by: Pedro Tanaka <[email protected]> Signed-off-by: Pedro Tanaka <[email protected]> Signed-off-by: Marshall Lang <[email protected]>
Signed-off-by: Marshall Lang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Verification
I ran a compactor using the "debug.accept-malformed-index" flag against prometheus block data affected by this prometheus issue. Using the latest Thanos release, the compactor would succeed (with warnings) compacting, but then crash upon downsampling. After updating the flag, downsampling will also succeed with warnings.