Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build with Go 1.19 #5753

Merged
merged 13 commits into from
Oct 5, 2022
Merged

Build with Go 1.19 #5753

merged 13 commits into from
Oct 5, 2022

Conversation

sylr
Copy link
Contributor

@sylr sylr commented Oct 3, 2022 •
edited
Loading

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Build with Go 1.19

Verification

@sylr
Build with Go 1.19
e94e594 
Signed-off-by: Sylvain Rabot <[email protected]>
@sylr
Run go fmt with go 1.19
44df985 
Signed-off-by: Sylvain Rabot <[email protected]>
@pull-request-size pull-request-size bot added size/L and removed size/M labels Oct 3, 2022
GiedriusS
GiedriusS reviewed Oct 4, 2022
View reviewed changes
Copy link
Member

@GiedriusS GiedriusS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two comments, otherwise LGTM

go.mod Outdated Show resolved Hide resolved
internal/cortex/chunk/encoding/varbit_helpers.go Show resolved Hide resolved
sylr added 2 commits October 4, 2022 10:45
@sylr
Add changelog entry
35c2192 
Signed-off-by: Sylvain Rabot <[email protected]>
@sylr
Revert go version in go.mod
db41796 
Signed-off-by: Sylvain Rabot <[email protected]>
GiedriusS
GiedriusS previously approved these changes Oct 4, 2022
View reviewed changes
sylr added 3 commits October 4, 2022 11:27
@sylr
Upgrade faillint to v1.11.0
511552b 
Signed-off-by: Sylvain Rabot <[email protected]>
@sylr
Upgrade github.com/golangci/golangci-lint to v1.49.0
f03392b 
Signed-off-by: Sylvain Rabot <[email protected]>
@sylr
Remove deprecated linters
4d94331 
```
WARN [runner] The linter 'deadcode' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter.  Replaced by unused.
WARN [runner] The linter 'varcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter.  Replaced by unused.
WARN [runner] The linter 'structcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter.  Replaced by unused.
WARN [linters context] structcheck is disabled because of generics. You can track the evolution of the generics support by following the golangci/golangci-lint#2649.
```

Signed-off-by: Sylvain Rabot <[email protected]>
@pull-request-size pull-request-size bot added size/XL and removed size/L labels Oct 4, 2022
@sylr
Regen proto files
2501234 
Signed-off-by: Sylvain Rabot <[email protected]>
@sylr sylr marked this pull request as draft October 4, 2022 10:03
sylr added 3 commits October 4, 2022 12:31
@sylr
Fix typo
544c858 
Signed-off-by: Sylvain Rabot <[email protected]>
@sylr
Format docs
cf9c15d 
Signed-off-by: Sylvain Rabot <[email protected]>
@sylr
Upgrade gopsutil to v3.22.9
e490e0c 
Signed-off-by: Sylvain Rabot <[email protected]>
@sylr sylr marked this pull request as ready for review October 4, 2022 15:37
@sylr sylr requested a review from GiedriusS October 5, 2022 10:38
GiedriusS
GiedriusS approved these changes Oct 5, 2022
View reviewed changes
Copy link
Member

@GiedriusS GiedriusS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

@GiedriusS GiedriusS merged commit 7b927cf into thanos-io:main Oct 5, 2022
GiedriusS
GiedriusS reviewed Oct 5, 2022
View reviewed changes
Copy link
Member

@GiedriusS GiedriusS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for always taking care of these upgrades 😄

douglascamata pushed a commit to douglascamata/thanos that referenced this pull request Oct 6, 2022
@sylr @douglascamata
Build with Go 1.19 (thanos-io#5753)
bed3923 
* Build with Go 1.19

Signed-off-by: Sylvain Rabot <[email protected]>

* Run go fmt with go 1.19

Signed-off-by: Sylvain Rabot <[email protected]>

* Add changelog entry

Signed-off-by: Sylvain Rabot <[email protected]>

* Revert go version in go.mod

Signed-off-by: Sylvain Rabot <[email protected]>

* Upgrade faillint to v1.11.0

Signed-off-by: Sylvain Rabot <[email protected]>

* Upgrade github.com/golangci/golangci-lint to v1.49.0

Signed-off-by: Sylvain Rabot <[email protected]>

* Remove deprecated linters

```
WARN [runner] The linter 'deadcode' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter.  Replaced by unused.
WARN [runner] The linter 'varcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter.  Replaced by unused.
WARN [runner] The linter 'structcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter.  Replaced by unused.
WARN [linters context] structcheck is disabled because of generics. You can track the evolution of the generics support by following the golangci/golangci-lint#2649.
```

Signed-off-by: Sylvain Rabot <[email protected]>

* Regen proto files

Signed-off-by: Sylvain Rabot <[email protected]>

* Fix typo

Signed-off-by: Sylvain Rabot <[email protected]>

* Format docs

Signed-off-by: Sylvain Rabot <[email protected]>

* Upgrade gopsutil to v3.22.9

Signed-off-by: Sylvain Rabot <[email protected]>

* Display diff in the check-docs target

Signed-off-by: Sylvain Rabot <[email protected]>

* Fix macOS path in docs/components/tools.md

Signed-off-by: Sylvain Rabot <[email protected]>

Signed-off-by: Sylvain Rabot <[email protected]>
utukJ pushed a commit to utukJ/thanos that referenced this pull request Oct 13, 2022
@sylr @utukJ
Build with Go 1.19 (thanos-io#5753)
38da08b 
* Build with Go 1.19

Signed-off-by: Sylvain Rabot <[email protected]>

* Run go fmt with go 1.19

Signed-off-by: Sylvain Rabot <[email protected]>

* Add changelog entry

Signed-off-by: Sylvain Rabot <[email protected]>

* Revert go version in go.mod

Signed-off-by: Sylvain Rabot <[email protected]>

* Upgrade faillint to v1.11.0

Signed-off-by: Sylvain Rabot <[email protected]>

* Upgrade github.com/golangci/golangci-lint to v1.49.0

Signed-off-by: Sylvain Rabot <[email protected]>

* Remove deprecated linters

```
WARN [runner] The linter 'deadcode' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter.  Replaced by unused.
WARN [runner] The linter 'varcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter.  Replaced by unused.
WARN [runner] The linter 'structcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter.  Replaced by unused.
WARN [linters context] structcheck is disabled because of generics. You can track the evolution of the generics support by following the golangci/golangci-lint#2649.
```

Signed-off-by: Sylvain Rabot <[email protected]>

* Regen proto files

Signed-off-by: Sylvain Rabot <[email protected]>

* Fix typo

Signed-off-by: Sylvain Rabot <[email protected]>

* Format docs

Signed-off-by: Sylvain Rabot <[email protected]>

* Upgrade gopsutil to v3.22.9

Signed-off-by: Sylvain Rabot <[email protected]>

* Display diff in the check-docs target

Signed-off-by: Sylvain Rabot <[email protected]>

* Fix macOS path in docs/components/tools.md

Signed-off-by: Sylvain Rabot <[email protected]>

Signed-off-by: Sylvain Rabot <[email protected]>
Signed-off-by: utukj <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GiedriusS GiedriusS GiedriusS approved these changes

Assignees
No one assigned
Labels
size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sylr @GiedriusS