Use pre-calculated hashes #5817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fpetkovski
force-pushed
the
use-chunk-hashes
branch
2 times, most recently
from
97974ee to
750433b
Compare
Thanos stores can now calculate chunk hashes and send them as part of the series response. This commit modifies the dedup proxy to not calculate those hashes if they are available. Signed-off-by: Filip Petkovski <[email protected]>
fpetkovski
force-pushed
the
use-chunk-hashes
branch
from
750433b to
03553a9
Compare
GiedriusS
approved these changes
Oct 25, 2022
fpetkovski
added a commit
to fpetkovski/thanos
that referenced
this pull request
Oct 25, 2022
Thanos stores can now calculate chunk hashes and send them as part of the series response. This commit modifies the dedup proxy to not calculate those hashes if they are available. Signed-off-by: Filip Petkovski <[email protected]> Signed-off-by: Filip Petkovski <[email protected]>
GiedriusS
pushed a commit
to vinted/thanos
that referenced
this pull request
Oct 31, 2022
Thanos stores can now calculate chunk hashes and send them as part of the series response. This commit modifies the dedup proxy to not calculate those hashes if they are available. Signed-off-by: Filip Petkovski <[email protected]> Signed-off-by: Filip Petkovski <[email protected]>
ngraham20
pushed a commit
to ngraham20/thanos
that referenced
this pull request
May 18, 2023
Thanos stores can now calculate chunk hashes and send them as part of the series response. This commit modifies the dedup proxy to not calculate those hashes if they are available. Signed-off-by: Filip Petkovski <[email protected]> Signed-off-by: Filip Petkovski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanos stores can now calculate chunk hashes and send them as part of the series response.
This commit modifies the dedup proxy to not calculate those hashes if they are available.
Changes
Verification
Extended an existing unit test.