Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Updated documentation for OCI Object Storage, added link to blog post #5928

Merged
merged 1 commit into from
Nov 30, 2022

Conversation

hyder
Copy link
Contributor

@hyder hyder commented Nov 30, 2022

There is no functionality change, only updated documentation.

Signed-off-by: Ali Mukadam [email protected]

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Verification

saswatamcode
saswatamcode previously approved these changes Nov 30, 2022
Copy link
Member

@saswatamcode saswatamcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for fixing ToC as well.

Can you run make docs and commit, to fix the docs CI error?

@hyder
Copy link
Contributor Author

hyder commented Nov 30, 2022

LGTM! Thanks for fixing ToC as well.

Can you run make docs and commit, to fix the docs CI error?

Yep, already done.

Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thanks!

@yeya24 yeya24 merged commit 04106d7 into thanos-io:main Nov 30, 2022
ngraham20 pushed a commit to ngraham20/thanos that referenced this pull request May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants