Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: cut 0.30.1 #6017

Merged
merged 2 commits into from
Jan 4, 2023
Merged

*: cut 0.30.1 #6017

merged 2 commits into from
Jan 4, 2023

Conversation

GiedriusS
Copy link
Member

Pull in the Redis client fix + add a CHANGELOG entry.

* fix duplicate metrics registration in redis client

Signed-off-by: Kama Huang <[email protected]>

* fixed test

Signed-off-by: Kama Huang <[email protected]>

Signed-off-by: Kama Huang <[email protected]>
Add CHANGELOG entry.

Signed-off-by: Giedrius Statkevičius <[email protected]>
Copy link
Contributor

@douglascamata douglascamata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@GiedriusS GiedriusS merged commit 27e4714 into release-0.30 Jan 4, 2023
@GiedriusS GiedriusS deleted the release_031 branch January 4, 2023 17:58
GiedriusS added a commit that referenced this pull request Jan 17, 2023
* fix duplicate metrics registration in redis client (#6009)

* fix duplicate metrics registration in redis client

Signed-off-by: Kama Huang <[email protected]>

* fixed test

Signed-off-by: Kama Huang <[email protected]>

Signed-off-by: Kama Huang <[email protected]>

* *: cut 0.30.1

Add CHANGELOG entry.

Signed-off-by: Giedrius Statkevičius <[email protected]>

Signed-off-by: Kama Huang <[email protected]>
Signed-off-by: Giedrius Statkevičius <[email protected]>
Co-authored-by: Kama Huang <[email protected]>
Signed-off-by: Giedrius Statkevičius <[email protected]>
saswatamcode pushed a commit that referenced this pull request Jan 18, 2023
* compact: remove cancel on SyncMetas errors (#5923)

in a favour of 86b4039 SyncMetas will retry if it's retriable.
Also, the cleanPartialMarked calls are surrounded by runutil.Repeat() will be repeated,
the ones not and are not retriable will throw an interrupt to run.Group() by returning err
and Group will call cancel() as it's configured for its interrupt func.

Signed-off-by: Seena Fallah <[email protected]>

Signed-off-by: Seena Fallah <[email protected]>

* Cut v0.30.0-rc.0 (#5992)

* Cut v0.30.0-rc.0

Signed-off-by: bwplotka <[email protected]>

* mdox fix.

Signed-off-by: bwplotka <[email protected]>

Signed-off-by: bwplotka <[email protected]>
Signed-off-by: Giedrius Statkevičius <[email protected]>

* Cut 0.30.0 (#6011)

Signed-off-by: bwplotka <[email protected]>

Signed-off-by: bwplotka <[email protected]>
Signed-off-by: Giedrius Statkevičius <[email protected]>

* *: cut 0.30.1 (#6017)

* fix duplicate metrics registration in redis client (#6009)

* fix duplicate metrics registration in redis client

Signed-off-by: Kama Huang <[email protected]>

* fixed test

Signed-off-by: Kama Huang <[email protected]>

Signed-off-by: Kama Huang <[email protected]>

* *: cut 0.30.1

Add CHANGELOG entry.

Signed-off-by: Giedrius Statkevičius <[email protected]>

Signed-off-by: Kama Huang <[email protected]>
Signed-off-by: Giedrius Statkevičius <[email protected]>
Co-authored-by: Kama Huang <[email protected]>
Signed-off-by: Giedrius Statkevičius <[email protected]>

* Tracing: Fix sampler defaults (#5887)

* Fix sampler defaults

Signed-off-by: Matej Gera <[email protected]>

* Add CHANGELOG

Signed-off-by: Matej Gera <[email protected]>

* Replace checkout with git-shallow-clone (#5829)

Signed-off-by: Matej Gera <[email protected]>

Signed-off-by: Matej Gera <[email protected]>

Signed-off-by: Matej Gera <[email protected]>
Signed-off-by: Giedrius Statkevičius <[email protected]>

* CHANGELOG: fix

Signed-off-by: Giedrius Statkevičius <[email protected]>

Signed-off-by: Seena Fallah <[email protected]>
Signed-off-by: bwplotka <[email protected]>
Signed-off-by: Giedrius Statkevičius <[email protected]>
Signed-off-by: Kama Huang <[email protected]>
Signed-off-by: Matej Gera <[email protected]>
Co-authored-by: Seena Fallah <[email protected]>
Co-authored-by: Kama Huang <[email protected]>
Kartik-Garg added a commit to infracloudio/thanos that referenced this pull request Jan 18, 2023
Added re-try mechanism for store inital sync, where if the initial sync fails, it tries to do the initial sync again every 5 seconds for 15 seconds duration (total 3 re-tries for initial sync of store).

Signed-off-by: Kartik-Garg <[email protected]>

Store: Make initial sync more robust

Added re-try mechanism for store inital sync, where if the initial sync fails, it tries to do the initial sync again every 5 seconds for 15 seconds duration (total 3 re-tries for initial sync of store).

Signed-off-by: Kartik-Garg <[email protected]>

Merge release 0.30 into main (thanos-io#6041)

* compact: remove cancel on SyncMetas errors (thanos-io#5923)

in a favour of 86b4039 SyncMetas will retry if it's retriable.
Also, the cleanPartialMarked calls are surrounded by runutil.Repeat() will be repeated,
the ones not and are not retriable will throw an interrupt to run.Group() by returning err
and Group will call cancel() as it's configured for its interrupt func.

Signed-off-by: Seena Fallah <[email protected]>

Signed-off-by: Seena Fallah <[email protected]>

* Cut v0.30.0-rc.0 (thanos-io#5992)

* Cut v0.30.0-rc.0

Signed-off-by: bwplotka <[email protected]>

* mdox fix.

Signed-off-by: bwplotka <[email protected]>

Signed-off-by: bwplotka <[email protected]>
Signed-off-by: Giedrius Statkevičius <[email protected]>

* Cut 0.30.0 (thanos-io#6011)

Signed-off-by: bwplotka <[email protected]>

Signed-off-by: bwplotka <[email protected]>
Signed-off-by: Giedrius Statkevičius <[email protected]>

* *: cut 0.30.1 (thanos-io#6017)

* fix duplicate metrics registration in redis client (thanos-io#6009)

* fix duplicate metrics registration in redis client

Signed-off-by: Kama Huang <[email protected]>

* fixed test

Signed-off-by: Kama Huang <[email protected]>

Signed-off-by: Kama Huang <[email protected]>

* *: cut 0.30.1

Add CHANGELOG entry.

Signed-off-by: Giedrius Statkevičius <[email protected]>

Signed-off-by: Kama Huang <[email protected]>
Signed-off-by: Giedrius Statkevičius <[email protected]>
Co-authored-by: Kama Huang <[email protected]>
Signed-off-by: Giedrius Statkevičius <[email protected]>

* Tracing: Fix sampler defaults (thanos-io#5887)

* Fix sampler defaults

Signed-off-by: Matej Gera <[email protected]>

* Add CHANGELOG

Signed-off-by: Matej Gera <[email protected]>

* Replace checkout with git-shallow-clone (thanos-io#5829)

Signed-off-by: Matej Gera <[email protected]>

Signed-off-by: Matej Gera <[email protected]>

Signed-off-by: Matej Gera <[email protected]>
Signed-off-by: Giedrius Statkevičius <[email protected]>

* CHANGELOG: fix

Signed-off-by: Giedrius Statkevičius <[email protected]>

Signed-off-by: Seena Fallah <[email protected]>
Signed-off-by: bwplotka <[email protected]>
Signed-off-by: Giedrius Statkevičius <[email protected]>
Signed-off-by: Kama Huang <[email protected]>
Signed-off-by: Matej Gera <[email protected]>
Co-authored-by: Seena Fallah <[email protected]>
Co-authored-by: Kama Huang <[email protected]>
sshantel pushed a commit to sshantel/thanos that referenced this pull request Jan 28, 2023
* compact: remove cancel on SyncMetas errors (thanos-io#5923)

in a favour of 86b4039 SyncMetas will retry if it's retriable.
Also, the cleanPartialMarked calls are surrounded by runutil.Repeat() will be repeated,
the ones not and are not retriable will throw an interrupt to run.Group() by returning err
and Group will call cancel() as it's configured for its interrupt func.

Signed-off-by: Seena Fallah <[email protected]>

Signed-off-by: Seena Fallah <[email protected]>

* Cut v0.30.0-rc.0 (thanos-io#5992)

* Cut v0.30.0-rc.0

Signed-off-by: bwplotka <[email protected]>

* mdox fix.

Signed-off-by: bwplotka <[email protected]>

Signed-off-by: bwplotka <[email protected]>
Signed-off-by: Giedrius Statkevičius <[email protected]>

* Cut 0.30.0 (thanos-io#6011)

Signed-off-by: bwplotka <[email protected]>

Signed-off-by: bwplotka <[email protected]>
Signed-off-by: Giedrius Statkevičius <[email protected]>

* *: cut 0.30.1 (thanos-io#6017)

* fix duplicate metrics registration in redis client (thanos-io#6009)

* fix duplicate metrics registration in redis client

Signed-off-by: Kama Huang <[email protected]>

* fixed test

Signed-off-by: Kama Huang <[email protected]>

Signed-off-by: Kama Huang <[email protected]>

* *: cut 0.30.1

Add CHANGELOG entry.

Signed-off-by: Giedrius Statkevičius <[email protected]>

Signed-off-by: Kama Huang <[email protected]>
Signed-off-by: Giedrius Statkevičius <[email protected]>
Co-authored-by: Kama Huang <[email protected]>
Signed-off-by: Giedrius Statkevičius <[email protected]>

* Tracing: Fix sampler defaults (thanos-io#5887)

* Fix sampler defaults

Signed-off-by: Matej Gera <[email protected]>

* Add CHANGELOG

Signed-off-by: Matej Gera <[email protected]>

* Replace checkout with git-shallow-clone (thanos-io#5829)

Signed-off-by: Matej Gera <[email protected]>

Signed-off-by: Matej Gera <[email protected]>

Signed-off-by: Matej Gera <[email protected]>
Signed-off-by: Giedrius Statkevičius <[email protected]>

* CHANGELOG: fix

Signed-off-by: Giedrius Statkevičius <[email protected]>

Signed-off-by: Seena Fallah <[email protected]>
Signed-off-by: bwplotka <[email protected]>
Signed-off-by: Giedrius Statkevičius <[email protected]>
Signed-off-by: Kama Huang <[email protected]>
Signed-off-by: Matej Gera <[email protected]>
Co-authored-by: Seena Fallah <[email protected]>
Co-authored-by: Kama Huang <[email protected]>
ngraham20 pushed a commit to ngraham20/thanos that referenced this pull request Mar 16, 2023
* fix duplicate metrics registration in redis client (thanos-io#6009)

* fix duplicate metrics registration in redis client

Signed-off-by: Kama Huang <[email protected]>

* fixed test

Signed-off-by: Kama Huang <[email protected]>

Signed-off-by: Kama Huang <[email protected]>

* *: cut 0.30.1

Add CHANGELOG entry.

Signed-off-by: Giedrius Statkevičius <[email protected]>

Signed-off-by: Kama Huang <[email protected]>
Signed-off-by: Giedrius Statkevičius <[email protected]>
Co-authored-by: Kama Huang <[email protected]>
ngraham20 pushed a commit to ngraham20/thanos that referenced this pull request Apr 17, 2023
* fix duplicate metrics registration in redis client (thanos-io#6009)

* fix duplicate metrics registration in redis client

Signed-off-by: Kama Huang <[email protected]>

* fixed test

Signed-off-by: Kama Huang <[email protected]>

Signed-off-by: Kama Huang <[email protected]>

* *: cut 0.30.1

Add CHANGELOG entry.

Signed-off-by: Giedrius Statkevičius <[email protected]>

Signed-off-by: Kama Huang <[email protected]>
Signed-off-by: Giedrius Statkevičius <[email protected]>
Co-authored-by: Kama Huang <[email protected]>
ngraham20 pushed a commit to ngraham20/thanos that referenced this pull request Apr 17, 2023
* compact: remove cancel on SyncMetas errors (thanos-io#5923)

in a favour of 86b4039 SyncMetas will retry if it's retriable.
Also, the cleanPartialMarked calls are surrounded by runutil.Repeat() will be repeated,
the ones not and are not retriable will throw an interrupt to run.Group() by returning err
and Group will call cancel() as it's configured for its interrupt func.

Signed-off-by: Seena Fallah <[email protected]>

Signed-off-by: Seena Fallah <[email protected]>

* Cut v0.30.0-rc.0 (thanos-io#5992)

* Cut v0.30.0-rc.0

Signed-off-by: bwplotka <[email protected]>

* mdox fix.

Signed-off-by: bwplotka <[email protected]>

Signed-off-by: bwplotka <[email protected]>
Signed-off-by: Giedrius Statkevičius <[email protected]>

* Cut 0.30.0 (thanos-io#6011)

Signed-off-by: bwplotka <[email protected]>

Signed-off-by: bwplotka <[email protected]>
Signed-off-by: Giedrius Statkevičius <[email protected]>

* *: cut 0.30.1 (thanos-io#6017)

* fix duplicate metrics registration in redis client (thanos-io#6009)

* fix duplicate metrics registration in redis client

Signed-off-by: Kama Huang <[email protected]>

* fixed test

Signed-off-by: Kama Huang <[email protected]>

Signed-off-by: Kama Huang <[email protected]>

* *: cut 0.30.1

Add CHANGELOG entry.

Signed-off-by: Giedrius Statkevičius <[email protected]>

Signed-off-by: Kama Huang <[email protected]>
Signed-off-by: Giedrius Statkevičius <[email protected]>
Co-authored-by: Kama Huang <[email protected]>
Signed-off-by: Giedrius Statkevičius <[email protected]>

* Tracing: Fix sampler defaults (thanos-io#5887)

* Fix sampler defaults

Signed-off-by: Matej Gera <[email protected]>

* Add CHANGELOG

Signed-off-by: Matej Gera <[email protected]>

* Replace checkout with git-shallow-clone (thanos-io#5829)

Signed-off-by: Matej Gera <[email protected]>

Signed-off-by: Matej Gera <[email protected]>

Signed-off-by: Matej Gera <[email protected]>
Signed-off-by: Giedrius Statkevičius <[email protected]>

* CHANGELOG: fix

Signed-off-by: Giedrius Statkevičius <[email protected]>

Signed-off-by: Seena Fallah <[email protected]>
Signed-off-by: bwplotka <[email protected]>
Signed-off-by: Giedrius Statkevičius <[email protected]>
Signed-off-by: Kama Huang <[email protected]>
Signed-off-by: Matej Gera <[email protected]>
Co-authored-by: Seena Fallah <[email protected]>
Co-authored-by: Kama Huang <[email protected]>
ngraham20 pushed a commit to ngraham20/thanos that referenced this pull request Apr 17, 2023
* compact: remove cancel on SyncMetas errors (thanos-io#5923)

in a favour of 86b4039 SyncMetas will retry if it's retriable.
Also, the cleanPartialMarked calls are surrounded by runutil.Repeat() will be repeated,
the ones not and are not retriable will throw an interrupt to run.Group() by returning err
and Group will call cancel() as it's configured for its interrupt func.

Signed-off-by: Seena Fallah <[email protected]>

Signed-off-by: Seena Fallah <[email protected]>

* Cut v0.30.0-rc.0 (thanos-io#5992)

* Cut v0.30.0-rc.0

Signed-off-by: bwplotka <[email protected]>

* mdox fix.

Signed-off-by: bwplotka <[email protected]>

Signed-off-by: bwplotka <[email protected]>
Signed-off-by: Giedrius Statkevičius <[email protected]>

* Cut 0.30.0 (thanos-io#6011)

Signed-off-by: bwplotka <[email protected]>

Signed-off-by: bwplotka <[email protected]>
Signed-off-by: Giedrius Statkevičius <[email protected]>

* *: cut 0.30.1 (thanos-io#6017)

* fix duplicate metrics registration in redis client (thanos-io#6009)

* fix duplicate metrics registration in redis client

Signed-off-by: Kama Huang <[email protected]>

* fixed test

Signed-off-by: Kama Huang <[email protected]>

Signed-off-by: Kama Huang <[email protected]>

* *: cut 0.30.1

Add CHANGELOG entry.

Signed-off-by: Giedrius Statkevičius <[email protected]>

Signed-off-by: Kama Huang <[email protected]>
Signed-off-by: Giedrius Statkevičius <[email protected]>
Co-authored-by: Kama Huang <[email protected]>
Signed-off-by: Giedrius Statkevičius <[email protected]>

* Tracing: Fix sampler defaults (thanos-io#5887)

* Fix sampler defaults

Signed-off-by: Matej Gera <[email protected]>

* Add CHANGELOG

Signed-off-by: Matej Gera <[email protected]>

* Replace checkout with git-shallow-clone (thanos-io#5829)

Signed-off-by: Matej Gera <[email protected]>

Signed-off-by: Matej Gera <[email protected]>

Signed-off-by: Matej Gera <[email protected]>
Signed-off-by: Giedrius Statkevičius <[email protected]>

* CHANGELOG: fix

Signed-off-by: Giedrius Statkevičius <[email protected]>

Signed-off-by: Seena Fallah <[email protected]>
Signed-off-by: bwplotka <[email protected]>
Signed-off-by: Giedrius Statkevičius <[email protected]>
Signed-off-by: Kama Huang <[email protected]>
Signed-off-by: Matej Gera <[email protected]>
Co-authored-by: Seena Fallah <[email protected]>
Co-authored-by: Kama Huang <[email protected]>
ngraham20 pushed a commit to ngraham20/thanos that referenced this pull request May 17, 2023
* fix duplicate metrics registration in redis client (thanos-io#6009)

* fix duplicate metrics registration in redis client

Signed-off-by: Kama Huang <[email protected]>

* fixed test

Signed-off-by: Kama Huang <[email protected]>

Signed-off-by: Kama Huang <[email protected]>

* *: cut 0.30.1

Add CHANGELOG entry.

Signed-off-by: Giedrius Statkevičius <[email protected]>

Signed-off-by: Kama Huang <[email protected]>
Signed-off-by: Giedrius Statkevičius <[email protected]>
Co-authored-by: Kama Huang <[email protected]>
ngraham20 pushed a commit to ngraham20/thanos that referenced this pull request May 18, 2023
* fix duplicate metrics registration in redis client (thanos-io#6009)

* fix duplicate metrics registration in redis client

Signed-off-by: Kama Huang <[email protected]>

* fixed test

Signed-off-by: Kama Huang <[email protected]>

Signed-off-by: Kama Huang <[email protected]>

* *: cut 0.30.1

Add CHANGELOG entry.

Signed-off-by: Giedrius Statkevičius <[email protected]>

Signed-off-by: Kama Huang <[email protected]>
Signed-off-by: Giedrius Statkevičius <[email protected]>
Co-authored-by: Kama Huang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants