Expose info for each TSDB #6329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
fpetkovski
force-pushed
the
expose-tsdb-infos
branch
4 times, most recently
from
f855642 to
386d651
Compare
GiedriusS
reviewed
May 3, 2023
| func (s *ProxyStore) TSDBInfos() []infopb.TSDBInfo { | ||
| infos := make([]infopb.TSDBInfo, 0) | ||
| for _, store := range s.stores() { | ||
| infos = append(infos, store.TSDBInfos()...) |
There was a problem hiding this comment.
Do we need to filter out nil here if a store doesn't support this call?
There was a problem hiding this comment.
it seems that the spread operator can already handle nils. However, I added a test as a safeguard to make sure we don't have some weird regression in the future.
This commit exposes the label set alongside the min and max time for each TSDB covered by a Store. This information is used to scope the min time for a remote query so that we do not produce partial aggregates in distriuted mode. Signed-off-by: Filip Petkovski <[email protected]>
Signed-off-by: Filip Petkovski <[email protected]>
fpetkovski
force-pushed
the
expose-tsdb-infos
branch
from
940612f to
6fd6d2c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit exposes the label set alongside the min and max time for each TSDB covered by a Store.
This information is used to scope the min time for a remote query so that we do not produce partial aggregates in distriuted mode.
Changes
Verification