store/bucket: use roaring bitmaps for postings list #6357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiedriusS
force-pushed
the
postings_roaring_bitmaps
branch
from
515a029 to
1f72e8c
Compare
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
GiedriusS
force-pushed
the
postings_roaring_bitmaps
branch
4 times, most recently
from
6128daf to
9698427
Compare
GiedriusS
force-pushed
the
postings_roaring_bitmaps
branch
3 times, most recently
from
eba4623 to
42d2d72
Compare
TODO: description/tests/convert set operations into bitwise ops Signed-off-by: Giedrius Statkevičius <[email protected]>
GiedriusS
force-pushed
the
postings_roaring_bitmaps
branch
from
42d2d72 to
d986030
Compare
|
I think we missed one optimization opportunity here - currently fetching and intersection are two separate processes but we can join those two and reuse the same containers to avoid allocations. Let me try to refactor this and rebase on top of recent changes. |
|
@GiedriusS I am thinking if it is better to build the roaring bitmap postings offline at compactor? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: description/tests/convert set operations into bitwise ops
Changes
Verification