[sync part3] promclient: Added method for Prometheus snapshot. #730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwplotka
force-pushed
the
promclient-snapshot
branch
3 times, most recently
from
75a13c3 to
0e0b864
Compare
bwplotka
changed the title
domgreen
approved these changes
Jan 22, 2019
| } | ||
| resp, err := http.DefaultClient.Do(req.WithContext(ctx)) | ||
| if err != nil { | ||
| return Flags{}, errors.Wrapf(err, "request config against %s", u.String()) |
bwplotka
force-pushed
the
promclient-snapshot
branch
from
0e0b864 to
bbd0b52
Compare
bwplotka
force-pushed
the
promclient-snapshot
branch
from
bbd0b52 to
a8391db
Compare
bwplotka
force-pushed
the
promclient-snapshot
branch
from
a8391db to
8abd8d1
Compare
domgreen
approved these changes
Jan 30, 2019
FUSAKLA
approved these changes
Jan 30, 2019
| u := *base | ||
| u.Path = path.Join(u.Path, "/api/v1/admin/tsdb/snapshot") | ||
|
|
||
| req, err := http.NewRequest( |
There was a problem hiding this comment.
might be worth to check the ConfiguredFlags for the web.enable-admin-api?
If called more times it would cause overhead but on the other hand the check will provide always relevant hint what is the issue.
Or maybe just checking for 404 status on the napshot API url would be enough to give that hint.
There was a problem hiding this comment.
hm do you mean to use Configured Flags to check admin api flag e.g to tell if we can use snapshotting or not?
That is the plan, just not on this PR (:
There was a problem hiding this comment.
Yep, that's exactly what I had in mind. Ok :)
bwplotka
force-pushed
the
promclient
branch
2 times, most recently
from
ef254d1 to
02b0186
Compare
bwplotka
force-pushed
the
promclient-snapshot
branch
3 times, most recently
from
9dce393 to
737cf23
Compare
Also: * Resigned from tests against 2.0.0 version as in README. * Added foreach Prometheus version testutil. Signed-off-by: Bartek Plotka <[email protected]>
bwplotka
force-pushed
the
promclient-snapshot
branch
from
737cf23 to
e15f983
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for #731
Important follow up on this is #758
Signed-off-by: Bartek Plotka [email protected]