UI: Select time range with mouse drag feature #7853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reimirno
changed the title
Signed-off-by: Yu Long <[email protected]>
If a querier sees a "stats" parameter in the query request, it will attach important information about the query execution to the response. But currently, even if an user sets this value, the Query Frontend will lose this value in its middleware/roundtrippers. This PR fixes this problem by properly encoding/decoding the requests in QFE. Signed-off-by: Pedro Tanaka <[email protected]> Signed-off-by: Yu Long <[email protected]>
…-io#7851) Bumps [go.opentelemetry.io/otel/bridge/opentracing](https://github.com/open-telemetry/opentelemetry-go) from 1.29.0 to 1.31.0. - [Release notes](https://github.com/open-telemetry/opentelemetry-go/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-go/blob/main/CHANGELOG.md) - [Commits](open-telemetry/opentelemetry-go@v1.29.0...v1.31.0) --- updated-dependencies: - dependency-name: go.opentelemetry.io/otel/bridge/opentracing dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Yu Long <[email protected]>
Signed-off-by: Yu Long <[email protected]>
Reimirno
force-pushed
the
ui-mouse-select-time-range
branch
from
1623e8a to
71a4213
Compare
|
|
Signed-off-by: Yu Long <[email protected]>
Signed-off-by: Yu Long <[email protected]>
Signed-off-by: Yu Long <[email protected]>
|
Thanks for working on it! Please help fix the unit test. |
Signed-off-by: Yu Long <[email protected]>
MichaHoffmann
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Added mouse selection of time range feature to web UI.
Adapted from prometheus/prometheus@167dfa1
Verification
It's almost identical to prometheus impl, and I manually verified that it works. See screen recording below in comments.