Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix binary reader download duration histogram #8017

Merged
merged 3 commits into from
Jan 6, 2025
Merged

Fix binary reader download duration histogram #8017

merged 3 commits into from
Jan 6, 2025

Conversation

yeya24
Copy link
Contributor

@yeya24 yeya24 commented Dec 22, 2024 •
edited
Loading

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

  • Enable native histograms for thanos_indexheader_download_duration_seconds and thanos_indexheader_load_duration_seconds metrics.
  • We seem to accidentally use loadDuration histogram when we actually download the index header, which seems wrong. https://github.com/thanos-io/thanos/blob/main/pkg/block/indexheader/binary_reader.go#L575
  • When using newMemoryBinaryReader, we didn't track the latency to download index header there, this PR just puts the latency track inside WriteBinary to cover all cases.

Verification

@yeya24 yeya24 force-pushed the fix-binary-reader-download-duration branch from 4571381 to 95b68da Compare December 22, 2024 21:53
@yeya24 yeya24 force-pushed the fix-binary-reader-download-duration branch from 95b68da to d08cd61 Compare January 5, 2025 19:06
@yeya24 yeya24 requested a review from saswatamcode January 5, 2025 19:06
saswatamcode
saswatamcode approved these changes Jan 6, 2025
View reviewed changes
Copy link
Member

@saswatamcode saswatamcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@saswatamcode saswatamcode enabled auto-merge (squash) January 6, 2025 09:44
@yeya24 yeya24 disabled auto-merge January 6, 2025 17:34
@yeya24 yeya24 merged commit 0e95c46 into thanos-io:main Jan 6, 2025
21 of 22 checks passed
@yeya24 yeya24 deleted the fix-binary-reader-download-duration branch January 6, 2025 17:34
@yeya24 yeya24 mentioned this pull request Jan 6, 2025
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saswatamcode saswatamcode saswatamcode approved these changes

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yeya24 @saswatamcode