feat(reloader): allow passing http Header in the http reloader request #8042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RouxAntoine
force-pushed
the
feature/allow-passing-header-in-reloader
branch
from
1bae47a to
e837f2a
Compare
This could be usefull in case of secured remote API by passing Authorization header usecase here in prometheus config map reloader https://github.com/prometheus-operator/prometheus-operator/blob/release-0.73/cmd/prometheus-config-reloader/main.go#L170 when we call prometheus backend which could be password protected Signed-off-by: RouxAntoine <[email protected]>
RouxAntoine
force-pushed
the
feature/allow-passing-header-in-reloader
branch
from
e837f2a to
840355f
Compare
|
i don't think that it's necessary since the reloader can already take an |
Hello, thanks for reply, I though too, but don't find anything that allow to define request header in the |
|
you can use https://pkg.go.dev/k8s.io/client-go/transport#NewBasicAuthRoundTripper to override the default Transport. |
nice thanks, I will and close this 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This could be usefull in case of secured remote API by passing Authorization header usecase here in prometheus config map reloader
https://github.com/prometheus-operator/prometheus-operator/blob/release-0.73/cmd/prometheus-config-reloader/main.go#L170 when we call prometheus backend which could be password protected
Changes
adding Header list in
HttpReloaderstruct.adding optional
ReloadHeaderoption inreloader.Optionsparameter ofNewconstructor.Verification
Adding an unit test which check if
Authorizationheader exists in the request issued by reloader.