pkg/cachutil: Add test for AsyncOperationProcessor stop() behavior #8043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing implementation sometimes drops existing operations that are still on the queue when .stop() is called. If multiple communications in a select statement can proceed, one is chosen pseudo-randomly: https://go.dev/ref/spec#Select_statements This means that sometimes a processor worker will process a remaining operation, and sometimes it won't. Signed-off-by: Daniel Sabsay <[email protected]>
|
Great. This test fails in CI as expected: |
|
I will close this PR to prevent confusion. But the above shows that the test fails in CI. The fix (and test) is on #8044. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing implementation sometimes drops existing operations that are still on the queue when .stop() is called.
If multiple communications in a select statement can proceed, one is chosen pseudo-randomly: https://go.dev/ref/spec#Select_statements
This means that sometimes a processor worker will process a remaining operation, and sometimes it won't.
Changes
Verification
Will fix in a separate PR.