QFE: fixing stats middleware when cache is enabled #8046
Merged
+10
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pedro Tanaka <[email protected]>
pedro-stanaka
force-pushed
the
fix/stats-middleware-caching
branch
from
db1d9fe to
2a22435
Compare
pedro-stanaka
commented
Jan 8, 2025
pkg/queryfrontend/config.go
Outdated
Comment on lines
259
to
261
| if err := cfg.QueryRangeConfig.ResultsCacheConfig.Validate(querier.Config{ | ||
| EnablePerStepStats: cfg.QueryRangeConfig.ResultsCacheConfig.CacheQueryableSamplesStats, | ||
| }); err != nil { |
There was a problem hiding this comment.
Had to do this because of validation of parameters in Cortex QFE code. They compare QFE config against Cortex Querier config. But we ignore/dont use that querier config, so I had to force that to pass validation. Or I can delete the validation piece, but then we will have to touch vendored code.
There was a problem hiding this comment.
Maybe we can extract the config in a variable to make it a bit more readable, and add a short comment above it.
There was a problem hiding this comment.
Good idea. done
Signed-off-by: Pedro Tanaka <[email protected]>
fpetkovski
approved these changes
Jan 8, 2025
saswatamcode
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes