Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] Async op test #8048

Closed
wants to merge 2 commits into from
Closed

Conversation

dsabsay
Copy link
Contributor

@dsabsay dsabsay commented Jan 8, 2025

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Verification

Just testing CI.

Daniel Sabsay added 2 commits January 6, 2025 16:25
The existing implementation sometimes drops existing operations that are
still on the queue when .stop() is called.

If multiple communications in a select statement can proceed, one is
chosen pseudo-randomly: https://go.dev/ref/spec#Select_statements

This means that sometimes a processor worker will process a remaining
operation, and sometimes it won't.

Signed-off-by: Daniel Sabsay <[email protected]>
Signed-off-by: Daniel Sabsay <[email protected]>
@dsabsay
Copy link
Contributor Author

dsabsay commented Jan 8, 2025

Fails as expected:

--- FAIL: TestAsyncOp (0.00s)
    testutil.go:91: async_op_test.go:35: ""
        
        	exp: 100
        
        	got: 22
        
FAIL

@dsabsay dsabsay closed this Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant