Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove some white noise #947

Merged
merged 2 commits into from
Mar 21, 2019
Merged

Remove some white noise #947

merged 2 commits into from
Mar 21, 2019

Conversation

daixiang0
Copy link
Member

Signed-off-by: Xiang Dai [email protected]

Changes

Delete all duplicate blank in docs.

@daixiang0
Remove some white noise
5aa4229 
Signed-off-by: Xiang Dai <[email protected]>
@domgreen
Copy link
Contributor

Did you run make after this? I wonder if our make docs step is actually adding this white space? Can you double check and I can have a look when I'm at my laptop.

@GiedriusS
Copy link
Member

GiedriusS commented Mar 20, 2019 •
edited
Loading

Thank you for your contribution! However, make docs adds these automatically for some reason. Could you check it out? The CI fails because of it now :(

@daixiang0
Copy link
Member Author

@domgreen @GiedriusS i make failed from my branch:

$ make docs
>> formatting code
go: verifying github.com/grpc-ecosystem/[email protected]: checksum mismatch
	downloaded: h1:BWIsLfhgKhV5g/oF34aRjniBHLTZe5DNekSjbAjIS6c=
	go.sum:     h1:Iju5GlWwrvL6UBg4zJJt3btmonfrMlCDdsejg4CZE7c=

switch to upstream/master, still failed, post in slack but no feedback.

@daixiang0
Copy link
Member Author

daixiang0 commented Mar 21, 2019 •
edited
Loading

@domgreen @GiedriusS i find root cause

GiedriusS
GiedriusS approved these changes Mar 21, 2019
View reviewed changes
Copy link
Member

@GiedriusS GiedriusS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! The only other 3 lines which were added is the sed part. Thank you a lot for fixing this! 👍

@GiedriusS GiedriusS merged commit 51e3672 into thanos-io:master Mar 21, 2019
@daixiang0 daixiang0 deleted the delete-blanks branch March 22, 2019 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GiedriusS GiedriusS GiedriusS approved these changes

Assignees
No one assigned
Labels
component: website/docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daixiang0 @domgreen @GiedriusS