-
Notifications
You must be signed in to change notification settings - Fork 686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RESTHeart 8.0 #7471
RESTHeart 8.0 #7471
Conversation
It is a bug open our end |
@@ -9,7 +9,7 @@ | |||
<properties> | |||
<maven.compiler.source>21</maven.compiler.source> | |||
<maven.compiler.target>21</maven.compiler.target> | |||
<restheart.version>8.0.0-beta</restheart.version> | |||
<restheart.version>[8.0,8.1.0-SNAPSHOT)</restheart.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is to guarantee to keep in 8.0.x
Side note :
Is there a way to use [8.0,8.1)
and to exclude all releases containing SNAPSHOT string in its name. I know that some artefact on java world are named 4.1-RC but are 4.0 and not 4.1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with <restheart.version>[8.0,8.1)</restheart.version>
the version 8.1.0-SNAPSHOT
would be picked up. mvn is quite wierd with range version and this is the only way I found to exclude 8.1.0-SNAPSHOT
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok then, let's use this.
But you prefer to use gradle, be my guest. The package manager depends on the framework choice (I mean I prefer to use what developers of framework recommend)
java/restheart/pom.xml
Outdated
|
||
<!-- avoids including following artifacts in shaded jar--> | ||
<dependency> | ||
<groupId>org.graalvm.polyglot</groupId> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why graalvm here ?
The Dockerfile specify temurin.
PS : I plan to make all java framework run on temurin and graalvm to check also memory usage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
setting those transitive dependencies of restheart will avoid including them in the shaded jar. Why this is happening is not yet clear, but we are fixing it in our pom.xml. latest version still requires this (however it would just produce some warnings by the maven shade plugin)
btw those dependencies are used by restheart to execute JavaScript plugins (when running on GraalVM). See https://restheart.org/docs/plugins/core-plugins-js
For this release, better to exclude them defining their scope as provided
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Executing the tests on both Temurin and GraalVM would be absolutely fantastic 🚀! I would love to see this implemented!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for this transitive dependencies, we have now an issue. hope to fix it soon SoftInstigate/restheart#510
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
btw I found a better way to exclude transitive deps...see my last commit
…plugin configuration
we just released RESTHeart 8.0.
note: RESTHeart runs on Java 21. I'm not sure why it is listed as
java (11)
in the results (like any other java framework).