feat: QL Events settings tab added and schema organized #55
Conversation
includes/class-admin.php
Outdated
| public function __construct() { | ||
| add_action( 'graphql_register_settings', [ $this, 'register_settings' ] ); | ||
| } |
There was a problem hiding this comment.
Not a required change, but I would love to avoid adding filters on a construct, it prevents a misfire of double hooking if we move it to a hook() method
includes/admin/class-general.php
Outdated
| * @return array | ||
| */ | ||
| public static function get_fields() { | ||
| $test_mode_status = (bool) defined( 'QL_EVENTS_TEST_MODE' ) && QL_EVENTS_TEST_MODE ? 'force enabled' : 'force disabled'; |
There was a problem hiding this comment.
I wounder if we should have a method for the test mode verification.
Cuz I was rushing lol |
| 'resolve' => function( $source ) { | ||
| $decorator = tribe( Attendee::class ); | ||
| $decorated_attendee = $decorator->get_attendee( get_post( $source->ID ) ); | ||
|
|
||
| $meta = tribe( 'tickets-plus.meta' ); | ||
| $attendee_meta_data = $meta->get_attendee_meta_fields( $decorated_attendee->ticket_id, $decorated_attendee->ID ); | ||
| if ( isset( $attendee_meta_data[0] ) ) { | ||
| unset( $attendee_meta_data[0] ); | ||
| } | ||
|
|
||
| if ( ! is_array( $attendee_meta_data ) ) { | ||
| return []; | ||
| } | ||
|
|
||
| return array_map( | ||
| function( $key, $value ) { | ||
| return (object) compact( 'value', 'key' ); | ||
| }, | ||
| array_keys( $attendee_meta_data ), | ||
| array_values( $attendee_meta_data ) | ||
| ); | ||
| }, |
There was a problem hiding this comment.
Not for this PR, but I would love to see us move towards having the actual method live in this class, and we pass it as a Callable here. Feels like it would be better for long term unit testing and readability.
There was a problem hiding this comment.
What method are you referring to?
There was a problem hiding this comment.
To the actual function that is assigned to the 'resolve' key, I would love for us to go towards using methods from this class, instead of anonymous functions. Which will make the code harder to test and read down the line.
| default: | ||
| $type = apply_filters( 'ql_events_resolve_ticket_type', null, $value ); |
| default: | ||
| $type = apply_filters( 'ql_events_resolve_tec_order_type', null, $value ); |
| default: | ||
| $type = apply_filters( 'ql_events_resolve_attendee_type', null, $value ); |
| * | ||
| * @param array $ticket_classes - TEC ticket class names. |
There was a problem hiding this comment.
It would be cool to see some @since TBD in the docblocks.
Co-authored-by: Gustavo Bordoni <[email protected]>
Summary