Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Help Hub FF Fixes for spreadsheet #2300

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Help Hub FF Fixes for spreadsheet #2300

merged 1 commit into from
Nov 27, 2024

Conversation

redscar
Copy link
Contributor

@redscar redscar commented Nov 26, 2024 •
edited
Loading

🗒️ Description

This fixes #39, and #41 on the FF spreadsheet https://docs.google.com/spreadsheets/d/19_VNSbR426WqHBNS9DghOuyQsua5ZO_eTDgWg9JZco8/edit?gid=0#gid=0

🎥 Artifacts

image

@redscar redscar self-assigned this Nov 26, 2024
@redscar redscar added the code review Status: requires a code review. label Nov 27, 2024
@redscar redscar marked this pull request as ready for review November 27, 2024 15:52
Camwyn
Camwyn approved these changes Nov 27, 2024
View reviewed changes
Copy link
Member

@Camwyn Camwyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tiny note, not necessary to change.

src/resources/postcss/help-hub.pcss Show resolved Hide resolved
@redscar redscar merged commit e5953f5 into bucket/Help_Hub-FF Nov 27, 2024
16 of 17 checks passed
@redscar redscar deleted the tweak/Help_Hub-FF_Spreadsheet branch November 27, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Camwyn Camwyn Camwyn approved these changes

Assignees

@redscar redscar

Labels
code review Status: requires a code review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@redscar @Camwyn