Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In the context of tribe-common, there is no pluginName of note #35

Merged
merged 2 commits into from
Nov 20, 2015

Conversation

borkweb
Copy link
Member

@borkweb borkweb commented Nov 19, 2015

@borkweb borkweb added the code review Status: requires a code review. label Nov 19, 2015
@bordoni
Copy link
Member

bordoni commented Nov 20, 2015

Why not mention that the message came from Common, or at least from which common it came from.

@borkweb
Copy link
Member Author

borkweb commented Nov 20, 2015

Yeah, that seems reasonable. Added.

@tr1b0t
Copy link

tr1b0t commented Nov 20, 2015

Status Message Line
Don't leave error_log lying around Debug.php:37
Don't leave error_log lying around Debug.php:39

via jenkins/codesniffer-phpcs

@bordoni
Copy link
Member

bordoni commented Nov 20, 2015

004

@bordoni bordoni added merge Status: ready to merge. and removed code review Status: requires a code review. labels Nov 20, 2015
borkweb added a commit that referenced this pull request Nov 20, 2015
In the context of tribe-common, there is no pluginName of note
@borkweb borkweb merged commit 02cb6bd into release/121 Nov 20, 2015
@borkweb borkweb deleted the fix/41695-squash-notice branch November 20, 2015 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge Status: ready to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants