set max-w-[1392px] for navbar on light only pages
#2002
Conversation
🦋 Changeset detectedLatest commit: bbc679e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| <body | ||
| className={cn( | ||
| className, | ||
| isLightOnlyPage && 'light text-green-1000 [&_#h-navmenu-container]:max-w-[1392px]', |
There was a problem hiding this comment.
The width and light mode forcing shouldn't be connected IMHO.
We already have dark mode pages with narrower width, take a look at the comment in #1995 please.
There was a problem hiding this comment.
There was a problem hiding this comment.
So I'd add <HiveLayoutConfig widths="landing-narrow" /> to that Modules page.
There was a problem hiding this comment.
but this is the actual case in hive?
There was a problem hiding this comment.
It was, but I fixed it in the Components v9 / Nextra 4 branch. Hive main is "outdated" compared to Components.
Case Studies pages is narrow, but dark-friendly.
I realize it makes the code more complex, but I think we're getting asked about dark more by users every now and then, so decoupling this would help us have more dark mode pages.
fix https://guild-oss.slack.com/archives/C07DYCW4NUD/p1737483512872679?thread_ts=1737481301.066699&cid=C07DYCW4NUD