Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update retrieved kv after 5 minutes #113

Merged
merged 4 commits into from
Oct 18, 2022
Merged

Update retrieved kv after 5 minutes #113

merged 4 commits into from
Oct 18, 2022

Conversation

Razzmatazzz
Copy link
Member

Currently, a worker only retrieves data from a KV once. If that worker persists, then it won't ever update the KV data. This update ensures that workers will request new KV data if the last retrieval was more than 5 minutes ago.

@Razzmatazzz Razzmatazzz requested a review from a team as a code owner October 16, 2022 22:51
@github-actions
Copy link
Contributor

👋 Thanks for opening a pull request!

If you are new, please check out the trimmed down summary of our deployment process below:

  1. 👀 Observe the CI jobs and tests to ensure they are passing

  2. ✔️ Obtain an approval/review on this pull request

  3. 🚀 Deploy your pull request to the development environment with .deploy dev

  4. 🚀 Deploy your pull request to the production environment with .deploy

    If anything goes wrong, rollback with .deploy main

  5. 🎉 Merge!

@Razzmatazzz
Copy link
Member Author

.deploy to development

@github-actions
Copy link
Contributor

Deployment Triggered 🚀

Razzmatazzz, started a branch deployment to development

You can watch the progress here 🔗

Branch: update-stale-kv

@github-actions github-actions bot temporarily deployed to development October 16, 2022 22:52 Inactive
@github-actions
Copy link
Contributor

API Deployment - Development 🪐

The API has been deployed to the development environment 🚀

Pusher: @Razzmatazzz, Action: issue_comment, Workflow: branch-deploy

@github-actions
Copy link
Contributor

Deployment Results ✅

Razzmatazzz successfully deployed branch update-stale-kv to development

@Razzmatazzz
Copy link
Member Author

.deploy

@github-actions
Copy link
Contributor

Deployment Triggered 🚀

Razzmatazzz, started a branch deployment to production

You can watch the progress here 🔗

Branch: update-stale-kv

@github-actions github-actions bot temporarily deployed to production October 16, 2022 22:54 Inactive
@github-actions
Copy link
Contributor

API Deployment - Production 🌔

The API has been deployed to the production environment 🚀

Pusher: @Razzmatazzz, Action: issue_comment, Workflow: branch-deploy

@github-actions
Copy link
Contributor

Deployment Results ✅

Razzmatazzz successfully deployed branch update-stale-kv to production

GrantBirki
GrantBirki previously approved these changes Oct 17, 2022
View reviewed changes
Shebuka
Shebuka previously approved these changes Oct 17, 2022
View reviewed changes
@Razzmatazzz Razzmatazzz dismissed stale reviews from Shebuka and GrantBirki via 2ce1a2c October 17, 2022 12:38
@Razzmatazzz
Copy link
Member Author

.deploy to development

@github-actions
Copy link
Contributor

Deployment Triggered 🚀

Razzmatazzz, started a branch deployment to development

You can watch the progress here 🔗

Branch: update-stale-kv

@github-actions github-actions bot temporarily deployed to development October 17, 2022 12:40 Inactive
@github-actions
Copy link
Contributor

API Deployment - Development 🪐

The API has been deployed to the development environment 🚀

Pusher: @Razzmatazzz, Action: issue_comment, Workflow: branch-deploy

@github-actions
Copy link
Contributor

Deployment Results ✅

Razzmatazzz successfully deployed branch update-stale-kv to development

@Razzmatazzz
Copy link
Member Author

.deploy

@github-actions
Copy link
Contributor

Deployment Triggered 🚀

Razzmatazzz, started a branch deployment to production

You can watch the progress here 🔗

Branch: update-stale-kv

@github-actions github-actions bot temporarily deployed to production October 17, 2022 12:43 Inactive
@github-actions
Copy link
Contributor

API Deployment - Production 🌔

The API has been deployed to the production environment 🚀

Pusher: @Razzmatazzz, Action: issue_comment, Workflow: branch-deploy

@github-actions
Copy link
Contributor

Deployment Results ✅

Razzmatazzz successfully deployed branch update-stale-kv to production

@Razzmatazzz Razzmatazzz merged commit a46b590 into main Oct 18, 2022
@Razzmatazzz Razzmatazzz deleted the update-stale-kv branch October 18, 2022 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GrantBirki GrantBirki GrantBirki approved these changes

@Shebuka Shebuka Shebuka left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Razzmatazzz @Shebuka @GrantBirki