Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate kvs #56

Merged
merged 25 commits into from
Jun 20, 2022
Merged

Separate kvs #56

merged 25 commits into from
Jun 20, 2022

Conversation

Razzmatazzz
Copy link
Member

@Razzmatazzz Razzmatazzz commented Jun 20, 2022 •
edited
Loading

  • Uses separate KVs for production and development
  • Reduces total number of KVs used
  • Reads KV metadata to determine compression and encoding
  • Skips caching by default in development

resolves: #56

Razzmatazzz added 20 commits June 10, 2022 09:11
@Razzmatazzz Razzmatazzz requested a review from a team as a code owner June 20, 2022 13:00
@Razzmatazzz Razzmatazzz temporarily deployed to development June 20, 2022 13:00 Inactive
@github-actions
Copy link
Contributor

👋 Thanks for opening a pull request!

If you are new, please check out the trimmed down summary of our deployment process below:

  1. 👀 Observe the CI jobs and tests to ensure they are passing

  2. ✔️ Obtain an approval/review on this pull request

  3. 🚀 Branch deploy your pull request to production

    Comment .deploy on this pull request to trigger a deploy. If anything goes wrong, rollback with .deploy main

  4. 🎉 Merge!

Please note, this repository handles branch deployments a bit differently than our others. As soon as you open a pull request or push new commits, your branch is automatically deploy to development. This is by design to allow for rapid testing. To deploy to production, that part is all standard and you can follow the steps as seen above. Thanks!

@Razzmatazzz Razzmatazzz temporarily deployed to development June 20, 2022 13:02 Inactive
@github-actions
Copy link
Contributor

API Deployment - Development 🪐

The API has been deployed to the development environment 🚀

Pusher: @Razzmatazzz, Action: pull_request, Workflow: pull_request

1 similar comment
@github-actions
Copy link
Contributor

API Deployment - Development 🪐

The API has been deployed to the development environment 🚀

Pusher: @Razzmatazzz, Action: pull_request, Workflow: pull_request

@Razzmatazzz Razzmatazzz temporarily deployed to development June 20, 2022 14:01 Inactive
@github-actions
Copy link
Contributor

API Deployment - Development 🪐

The API has been deployed to the development environment 🚀

Pusher: @Razzmatazzz, Action: pull_request, Workflow: pull_request

@Razzmatazzz Razzmatazzz temporarily deployed to development June 20, 2022 14:13 Inactive
@github-actions
Copy link
Contributor

API Deployment - Development 🪐

The API has been deployed to the development environment 🚀

Pusher: @Razzmatazzz, Action: pull_request, Workflow: pull_request

@Razzmatazzz Razzmatazzz temporarily deployed to development June 20, 2022 14:30 Inactive
@github-actions
Copy link
Contributor

API Deployment - Development 🪐

The API has been deployed to the development environment 🚀

Pusher: @Razzmatazzz, Action: pull_request, Workflow: pull_request

GrantBirki
GrantBirki previously approved these changes Jun 20, 2022
View reviewed changes
@Razzmatazzz
Copy link
Member Author

.deploy

@github-actions
Copy link
Contributor

Deployment Triggered

Razzmatazzz, started a branch deployment 🚀

  • Branch: separate-kvs
  • Mode: branch

You can watch the progress here 🔗

@github-actions github-actions bot had a problem deploying to production June 20, 2022 21:44 Failure
@github-actions
Copy link
Contributor

Deployment Results

  • Status: failure ❌
  • Mode: branch 🚀
  • Branch: separate-kvs

Failure when deploying branch separate-kvs

Actor: Razzmatazzz, Action: issue_comment, Workflow: branch-deploy

@Razzmatazzz Razzmatazzz temporarily deployed to development June 20, 2022 21:50 Inactive
@github-actions
Copy link
Contributor

API Deployment - Development 🪐

The API has been deployed to the development environment 🚀

Pusher: @Razzmatazzz, Action: pull_request, Workflow: pull_request

@Razzmatazzz
Copy link
Member Author

.deploy

@github-actions
Copy link
Contributor

Deployment Triggered

Razzmatazzz, started a branch deployment 🚀

  • Branch: separate-kvs
  • Mode: branch

You can watch the progress here 🔗

@github-actions github-actions bot temporarily deployed to production June 20, 2022 22:21 Inactive
@github-actions
Copy link
Contributor

Deployment Results

  • Status: success ✔️
  • Mode: branch 🚀
  • Branch: separate-kvs

Successfully deployed branch separate-kvs

Actor: Razzmatazzz, Action: issue_comment, Workflow: branch-deploy

@Razzmatazzz Razzmatazzz merged commit 2a41915 into main Jun 20, 2022
@Razzmatazzz Razzmatazzz deleted the separate-kvs branch June 20, 2022 23:16
@Razzmatazzz Razzmatazzz mentioned this pull request Jun 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GrantBirki GrantBirki GrantBirki approved these changes

@thaddeus thaddeus thaddeus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Razzmatazzz @thaddeus @GrantBirki