Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add normalizedName to FleaMarket type #79

Merged
merged 2 commits into from
Jul 11, 2022
Merged

add normalizedName to FleaMarket type #79

merged 2 commits into from
Jul 11, 2022

Conversation

GrantBirki
Copy link
Member

add normalizedName to FleaMarket type

This PR adds the normalizedName field to the FleaMarket type. I'm unsure if this will work but going to try it out

resolves: #78

@GrantBirki GrantBirki requested a review from a team as a code owner July 10, 2022 03:08
@github-actions
Copy link
Contributor

👋 Thanks for opening a pull request!

If you are new, please check out the trimmed down summary of our deployment process below:

  1. 👀 Observe the CI jobs and tests to ensure they are passing

  2. ✔️ Obtain an approval/review on this pull request

  3. 🚀 Deploy your pull request to the development environment with .deploy dev

  4. 🚀 Deploy your pull request to the production environment with .deploy

    If anything goes wrong, rollback with .deploy main

  5. 🎉 Merge!

@GrantBirki
Copy link
Member Author

.deploy to development

@github-actions
Copy link
Contributor

Deployment Triggered

GrantBirki, started a branch deployment 🚀

  • Branch: fleamarket-schema-update
  • Mode: branch

You can watch the progress here 🔗

@github-actions github-actions bot temporarily deployed to development July 10, 2022 03:09 Inactive
@github-actions
Copy link
Contributor

API Deployment - Development 🪐

The API has been deployed to the development environment 🚀

Pusher: @GrantBirki, Action: issue_comment, Workflow: branch-deploy

@github-actions
Copy link
Contributor

Deployment Results

  • Status: success ✔️
  • Mode: branch 🚀
  • Branch: fleamarket-schema-update

Successfully deployed branch fleamarket-schema-update

Actor: GrantBirki, Action: issue_comment, Workflow: branch-deploy

Razzmatazzz
Razzmatazzz approved these changes Jul 11, 2022
View reviewed changes
Copy link
Member

@Razzmatazzz Razzmatazzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is how to make it available on the API side, but the data manager also needs to supply the value for the normalizedName attribute, which is handled here: the-hideout/tarkov-data-manager#96

@Razzmatazzz
Copy link
Member

.deploy

@github-actions
Copy link
Contributor

Deployment Triggered

Razzmatazzz, started a branch deployment 🚀

  • Branch: fleamarket-schema-update
  • Mode: branch

You can watch the progress here 🔗

@github-actions github-actions bot temporarily deployed to production July 11, 2022 13:58 Inactive
@github-actions
Copy link
Contributor

API Deployment - Production 🌔

The API has been deployed to the production environment 🚀

Pusher: @Razzmatazzz, Action: issue_comment, Workflow: branch-deploy

@github-actions
Copy link
Contributor

Deployment Results

  • Status: success ✔️
  • Mode: branch 🚀
  • Branch: fleamarket-schema-update

Successfully deployed branch fleamarket-schema-update

Actor: Razzmatazzz, Action: issue_comment, Workflow: branch-deploy

@Razzmatazzz Razzmatazzz merged commit 2ecd3a9 into main Jul 11, 2022
@Razzmatazzz Razzmatazzz deleted the fleamarket-schema-update branch July 11, 2022 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Razzmatazzz Razzmatazzz Razzmatazzz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Normalized name missing from FleaMarket
2 participants
@GrantBirki @Razzmatazzz