Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't cache responses with errors #94

Merged
merged 4 commits into from
Aug 20, 2022
Merged

Don't cache responses with errors #94

merged 4 commits into from
Aug 20, 2022

Conversation

Razzmatazzz
Copy link
Member

@Razzmatazzz Razzmatazzz commented Aug 19, 2022 •
edited
Loading

Also adds the variables to the query string for hashing so that identical queries using different variables are cached separately.

@Razzmatazzz Razzmatazzz requested a review from a team as a code owner August 19, 2022 19:19
@github-actions
Copy link
Contributor

👋 Thanks for opening a pull request!

If you are new, please check out the trimmed down summary of our deployment process below:

  1. 👀 Observe the CI jobs and tests to ensure they are passing

  2. ✔️ Obtain an approval/review on this pull request

  3. 🚀 Deploy your pull request to the development environment with .deploy dev

  4. 🚀 Deploy your pull request to the production environment with .deploy

    If anything goes wrong, rollback with .deploy main

  5. 🎉 Merge!

@Razzmatazzz
Copy link
Member Author

.deploy

@github-actions
Copy link
Contributor

Deployment Triggered

Razzmatazzz, started a branch deployment 🚀

  • Branch: no-cache-errors
  • Mode: branch

You can watch the progress here 🔗

@github-actions github-actions bot temporarily deployed to production August 19, 2022 19:22 Inactive
@github-actions
Copy link
Contributor

API Deployment - Production 🌔

The API has been deployed to the production environment 🚀

Pusher: @Razzmatazzz, Action: issue_comment, Workflow: branch-deploy

@github-actions
Copy link
Contributor

Deployment Results

  • Status: success ✔️
  • Mode: branch 🚀
  • Branch: no-cache-errors

Successfully deployed branch no-cache-errors

Actor: Razzmatazzz, Action: issue_comment, Workflow: branch-deploy

@Razzmatazzz
Copy link
Member Author

.deploy

@github-actions
Copy link
Contributor

Deployment Triggered

Razzmatazzz, started a branch deployment 🚀

  • Branch: no-cache-errors
  • Mode: branch

You can watch the progress here 🔗

@github-actions github-actions bot temporarily deployed to production August 20, 2022 04:43 Inactive
@github-actions
Copy link
Contributor

API Deployment - Production 🌔

The API has been deployed to the production environment 🚀

Pusher: @Razzmatazzz, Action: issue_comment, Workflow: branch-deploy

@github-actions
Copy link
Contributor

Deployment Results

  • Status: success ✔️
  • Mode: branch 🚀
  • Branch: no-cache-errors

Successfully deployed branch no-cache-errors

Actor: Razzmatazzz, Action: issue_comment, Workflow: branch-deploy

@Razzmatazzz
Copy link
Member Author

.deploy

@github-actions
Copy link
Contributor

Deployment Triggered

Razzmatazzz, started a branch deployment 🚀

  • Branch: no-cache-errors
  • Mode: branch

You can watch the progress here 🔗

@github-actions github-actions bot temporarily deployed to production August 20, 2022 14:23 Inactive
@github-actions
Copy link
Contributor

API Deployment - Production 🌔

The API has been deployed to the production environment 🚀

Pusher: @Razzmatazzz, Action: issue_comment, Workflow: branch-deploy

@github-actions
Copy link
Contributor

Deployment Results

  • Status: success ✔️
  • Mode: branch 🚀
  • Branch: no-cache-errors

Successfully deployed branch no-cache-errors

Actor: Razzmatazzz, Action: issue_comment, Workflow: branch-deploy

GrantBirki
GrantBirki approved these changes Aug 20, 2022
View reviewed changes
Copy link
Member

@GrantBirki GrantBirki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌟

@GrantBirki GrantBirki merged commit 154f43f into main Aug 20, 2022
@GrantBirki GrantBirki deleted the no-cache-errors branch August 20, 2022 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GrantBirki GrantBirki GrantBirki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Razzmatazzz @GrantBirki