Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Map controls styling #827

Merged
merged 7 commits into from
Jan 18, 2024
Merged

Map controls styling #827

merged 7 commits into from
Jan 18, 2024

Conversation

Razzmatazzz
Copy link
Member

@Razzmatazzz Razzmatazzz commented Jan 18, 2024 •
edited
Loading

Before:
image
After:
image

Also:

  • Adds option for hiding non-active quest markers
  • Allows leaflet map to resize to fill the window on window resize
  • Converts the top right map info box to a leaflet control
  • Moves coordinates to bottom left

@Razzmatazzz Razzmatazzz requested a review from a team as a code owner January 18, 2024 14:49
@github-actions GitHub Actions
Copy link
Contributor

👋 Thanks for opening a pull request!

If you are new, please check out the trimmed down summary of our deployment process below:

  1. 👀 Observe the CI jobs and tests to ensure they are passing

  2. ✔️ Obtain an approval/review on this pull request

  3. 🚀 Deploy your pull request to the development environment with .deploy to development

  4. 🚀 Deploy your pull request to the production environment with .deploy

    If anything goes wrong, rollback with .deploy main

  5. 🎉 Merge!

Note: If you have a larger change and want to block deployments, you can run .lock --reason <reason> to lock all other deployments (remove with .unlock)

You can view the branch deploy usage guide for additional information

@Razzmatazzz
Copy link
Member Author

.deploy to development

@github-actions GitHub Actions
Copy link
Contributor

Deployment Triggered 🚀

Razzmatazzz, started a branch deployment to development

You can watch the progress here 🔗

Branch: map-controls-styling

@github-actions GitHub Actions
Copy link
Contributor

Deployment Results ✅

Razzmatazzz successfully deployed branch map-controls-styling to development

Show Results

https://237f514d.tarkov-dev.pages.dev

@Shebuka
Copy link
Contributor

Shebuka commented Jan 18, 2024

Why do you put the fullscreen image as base64 inside CSS and not as an image in the interactive folder with all the other images?

@Razzmatazzz
Copy link
Member Author

Why do you put the fullscreen image as base64 inside CSS and not as an image in the interactive folder with all the other images?

Original image was the same.

@Shebuka
Copy link
Contributor

Shebuka commented Jan 18, 2024

.deploy

@github-actions GitHub Actions
Copy link
Contributor

⚠️ Cannot claim deployment lock

Sorry Shebuka, the production environment deployment lock is currently claimed by Razzmatazzz

Lock Details 🔒

  • Environment: production
  • Branch: 1278a4256205dd078b1051bf9599be9186c7d1d8
  • Created At: 2024-01-17T04:26:38.650Z
  • Created By: Razzmatazzz
  • Sticky: true
  • Global: false
  • Comment Link: click here
  • Lock Link: click here

The current lock has been active for 1d:13h:41m:52s

If you need to release the lock, please comment .unlock production

@Razzmatazzz
Copy link
Member Author

.unlock production

@github-actions GitHub Actions
Copy link
Contributor

🔓 Deployment Lock Removed

The production deployment lock has been successfully removed

@Razzmatazzz
Copy link
Member Author

.deploy to development

@github-actions GitHub Actions
Copy link
Contributor

Deployment Triggered 🚀

Razzmatazzz, started a branch deployment to development

You can watch the progress here 🔗

Branch: map-controls-styling

@github-actions GitHub Actions
Copy link
Contributor

Deployment Results ✅

Razzmatazzz successfully deployed branch map-controls-styling to development

Show Results

https://2ef02fe3.tarkov-dev.pages.dev

@Razzmatazzz
Copy link
Member Author

.deploy

@github-actions GitHub Actions
Copy link
Contributor

Deployment Triggered 🚀

Razzmatazzz, started a branch deployment to production

You can watch the progress here 🔗

Branch: map-controls-styling

@github-actions GitHub Actions
Copy link
Contributor

Deployment Results ✅

Razzmatazzz successfully deployed branch map-controls-styling to production

Environment URL: tarkov.dev

@Razzmatazzz
Copy link
Member Author

.deploy

@github-actions GitHub Actions
Copy link
Contributor

Deployment Triggered 🚀

Razzmatazzz, started a branch deployment to production

You can watch the progress here 🔗

Branch: map-controls-styling

@github-actions GitHub Actions
Copy link
Contributor

Deployment Results ✅

Razzmatazzz successfully deployed branch map-controls-styling to production

Environment URL: tarkov.dev

@Razzmatazzz Razzmatazzz merged commit 482715c into main Jan 18, 2024
2 checks passed
@Razzmatazzz Razzmatazzz deleted the map-controls-styling branch January 18, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shebuka Shebuka Shebuka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Razzmatazzz @Shebuka