Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output path configuration option + linebreak bugfix #12

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

GavrilovSV
Copy link

@GavrilovSV GavrilovSV commented Jun 29, 2022

Hey! We've found your plugin useful for our needs. However, there are couple of issues with it. First of all, it doesn't handle line breaks while generating md table. It means that property description javadocs having line breaks will mess output table up. We've also needed an opportunity to specify output file location since the default doesn't suit us. This PR solves these issues

@mastalx
Copy link

mastalx commented Jul 5, 2022

Wow - thanks! We'll look into it and release an update, as soon as @fhirt is back from his holidays

@mastalx mastalx requested a review from fhirt July 5, 2022 14:15
@mastalx mastalx changed the title Outputh path configuration option + linebreak bugfix Output path configuration option + linebreak bugfix Jul 5, 2022
@fhirt
Copy link
Contributor

fhirt commented Jul 27, 2022

hi @GavrilovSV - thanks for the contribution. Could you please describe the new input parameter here in the last section of the README.md? Then I will merge your changes.

@mastalx
Copy link

mastalx commented Aug 12, 2022

@fhirt: is it possible, that we can do the description ourselves, in order to make a new release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants