Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent ToC from repositioning when zoom is <100% #350

Merged
merged 1 commit into from
Sep 21, 2020
Merged

Prevent ToC from repositioning when zoom is <100% #350

merged 1 commit into from
Sep 21, 2020

Conversation

travisk-codes
Copy link
Contributor

Changes:

Screenshots:
Before:
tph-sidebar-before
After:
tph-sidebar-after

@veksen veksen force-pushed the 349-right-sidebar-position branch from ced26be to dafb8c2 Compare September 21, 2020 19:54
@veksen
Copy link
Collaborator

veksen commented Sep 21, 2020

I'm confused to why 1vw means anything here, that's 1% of the viewport.

@veksen
Copy link
Collaborator

veksen commented Sep 21, 2020

Also assuming this sort of fixes and allows #343 to move forward? You'll get to rebase it to master once this is merged and see how it reacts.

@veksen veksen merged commit 34754ac into the-programmers-hangout:master Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Sidebar ToC moves below content for <100% zoom
2 participants
@travisk-codes @veksen