Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix FIXMEs #384

Merged
merged 4 commits into from
Dec 2, 2024
Merged

fix FIXMEs #384

merged 4 commits into from
Dec 2, 2024

Conversation

CaptainSifff
Copy link
Collaborator

since we now have the DOI, we can resolve some FIXMEs.

@CaptainSifff CaptainSifff linked an issue Nov 27, 2024 that may be closed by this pull request
@CaptainSifff
Copy link
Collaborator Author

@jngrad I added the ref to bibliography.

@CaptainSifff CaptainSifff requested a review from knarrff November 27, 2024 10:19
@jngrad
Copy link
Collaborator

jngrad commented Nov 27, 2024

@jngrad I added the ref to bibliography.

You will need to update the submodule too:

git submodule update --remote bibliography
git add bibliography
git commit -m 'Synchronize bibliography'

@jngrad
Copy link
Collaborator

jngrad commented Nov 27, 2024

Our CI pipeline should fail when BibTeX entries are missing...

@jngrad
Copy link
Collaborator

jngrad commented Nov 27, 2024

The latexmk flag -Werror will now cause the CI/CD pipeline to fail when BibTeX entries are missing, or when labels are missing or duplicated.

@CaptainSifff
Copy link
Collaborator Author

thanks for fixing!

@CaptainSifff CaptainSifff merged commit 20a138b into main Dec 2, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix the FIXME once they can be fixed
2 participants