Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ANSI and ISO JSONs for GMMK2 p65 #1505

Merged
merged 1 commit into from
Oct 30, 2022
Merged

Update ANSI and ISO JSONs for GMMK2 p65 #1505

merged 1 commit into from
Oct 30, 2022

Conversation

adophoxia
Copy link
Contributor

@adophoxia adophoxia commented Oct 29, 2022 •
edited
Loading

Description

Redid the indexes to correctly be row:col instead of accidently being swapped to col:row

QMK Pull Request

qmk/qmk_firmware#18185 (p65)

Checklist

  • The VIA support for this keyboard is in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

@adophoxia
Update ANSI and ISO JSONs for GMMK2 p65
f703c7b 
Redid the indexes to correctly be `row:col` instead of accidently being swapped to `col:row`
@adophoxia adophoxia mentioned this pull request Oct 29, 2022
Closed
the-ashh
the-ashh approved these changes Oct 29, 2022
View reviewed changes
Copy link

@the-ashh the-ashh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Fixes #1497

@Xelus22 Xelus22 merged commit 236ff03 into the-via:master Oct 30, 2022
@Xelus22 Xelus22 linked an issue Oct 30, 2022 that may be closed by this pull request
GMMK2 p65 ANSI shows incorrect keymap on configure screen #1497
Closed
@adophoxia adophoxia deleted the gmmk2-fix branch October 30, 2022 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@the-ashh the-ashh the-ashh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GMMK2 p65 ANSI shows incorrect keymap on configure screen
3 participants
@adophoxia @the-ashh @Xelus22