Upgrade some dependencies to remove warning when using react 17 #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianwang
commented
Jun 28, 2021
| @@ -96,8 +96,8 @@ | |||
| "@babel/runtime": "^7.0.0", | |||
| "focus-lock": "^0.9.1", | |||
| "prop-types": "^15.6.2", | |||
There was a problem hiding this comment.
I'm wondering if we should move prop-types to peer dependency as well 🤔
There was a problem hiding this comment.
No. The general recommendation is to have it in deps.
theKashey
approved these changes
Jun 28, 2021
|
All tests are passed by the fact 🤷♂️ |
|
Thank you for the contribution |
|
Released as 2.5.2 |
This was referenced Jul 4, 2021
Merged
1 task
1 task
1 task
1 task
nickspaargaren
pushed a commit
to nickspaargaren/react-focus-lock
that referenced
this pull request
Dec 11, 2024
Upgrade some dependencies to remove warning when using react 17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm seeing the following error the installing the current
react-focus-lockafter upgrading those, I think all of them support react 17 as peer dependency so the warning should go away 👍