Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Halves of index registers #17

Closed
ammehet opened this issue Mar 7, 2020 · 3 comments
Closed

Halves of index registers #17

ammehet opened this issue Mar 7, 2020 · 3 comments
Labels
bug Something isn't working

Comments

@ammehet
Copy link

ammehet commented Mar 7, 2020

Instructions like LD XL,n and LD YH,r are not recognized while OR XL is processed correctly.
Also, LD IXL,n is recognized, but the calculated length is 2 bytes instead of 3.

@theNestruo
Copy link
Owner

Thanks for the report!
Both problems will be fixed in the next version.

It seems that instructions using any half (such as OR IXp) accepted multiple syntax for the register, while instructions using an specific half (such as LD IXl,n) were requiring a verbatim match (hence IXL was recognized but was not).

The size issue comes from the source Z80 instruction set data; I'll report it to the page maintainer.

theNestruo added a commit that referenced this issue Mar 8, 2020
Fixed issues: Halves of index registers not always recognized. #17
@ammehet
Copy link
Author

ammehet commented Mar 12, 2020

DEC L shows 2 bytes instead of 1.

@theNestruo
Copy link
Owner

LD HL,(NN) and IN F,(C) were also wrong.
They are all fixed now; both in this extension and in the Z80 Instruction Set source data.
Thanks!

@theNestruo theNestruo added the bug Something isn't working label Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants