Add the option to use a logo for the top left site title #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
regisphilibert
requested changes
Feb 5, 2020
| @@ -1,7 +1,11 @@ | |||
| <nav class="pv3 ph3 ph4-ns" role="navigation"> | |||
| <div class="flex-l justify-between items-center center"> | |||
| <a href="{{ .Site.BaseURL }}" class="f3 fw2 hover-white no-underline white-90 dib"> | |||
| {{ if .Site.Params.Logo }} | |||
There was a problem hiding this comment.
Thanks for this. Using with would make this a tiny bit less verbose (still for best practices promoting):
{{ with .Site.Params.Logo }}
<img src="{{ relURL . }}" alt="{{ $.Site.Title }}" />
{{ else }}
{{ .Site.Title }}
{{ end }}
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #81, but it does so slightly differently. It replaces the site title with a logo, in the navigation section, if Site.Params.Logo is set. If not it just continues to print the title, as it has up 'til now. Rather than Lithium's approach of having dimensions set under the logo parameter (see https://github.com/jrutheiser/hugo-lithium-theme/blob/master/exampleSite/config.toml) I just went for simplicity, figuring people would be happy to just set the dimensions in the image, or CSS, themselves.
This is my first hugo theme adjustment, so please check it over for any stupid mistakes!