RSS svg icon #282
Merged
RSS svg icon #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mountainbug95 this js file has been processed differently, any idea why? |
|
@regisphilibert I'm not quite sure why it is different. I had to redeploy the assets to get my added class for the rss icon to work. I'm sure that's what caused it. |
|
As the asset fingerpint is unchanged we don't need this file to be committed though. Any chance we can have it removed from the PR? |
|
sure thing |
Remicck
pushed a commit
to Remicck/gohugo-theme-ananke
that referenced
this pull request
Mar 7, 2022
* Add rss icon to social icons * Revert unnecessary asset deployment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #278