FIX: failed to remove policy from non-filled casbin model. #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If someone using model like the RBAC model that not fill 6 slot(v0-v5), while adding the policy to the database(I'm testing with postgresql) the empty slot will be treat as NULL.
In adapter.py#L63 and adapter.py#L73 are constructing the query with
""
(empty string) butNone
(NULL). It will never match any records in this situation, so policies will never be deleted(But casbin will delete them from its in-memory model which will break the consistency.)model e.g.