Skip to content

Commit

Permalink
[dvs] Mark unstable test cases as xfail (sonic-net#1223)
Browse files Browse the repository at this point in the history
- Disable VRF and NAT test cases due to VS image issues
- Disable DPB test case due to instability

Signed-off-by: Danny Allen
  • Loading branch information
daall authored Mar 16, 2020
1 parent 10aac0f commit a1ff711
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 5 deletions.
5 changes: 1 addition & 4 deletions tests/test_interface.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

from swsscommon import swsscommon


@pytest.mark.xfail(reason="vs image issue: Azure/sonic-sairedis#574")
class TestRouterInterface(object):
def setup_db(self, dvs):
self.pdb = swsscommon.DBConnector(0, dvs.redis_sock, 0)
Expand Down Expand Up @@ -490,7 +490,6 @@ def test_PortInterfaceAddRemoveIpv6AddressWithVrf(self, dvs, testlog):
if route["dest"] == "fc00::1/128":
assert False


def test_PortInterfaceAddRemoveIpv4AddressWithVrf(self, dvs, testlog):
self.setup_db(dvs)

Expand Down Expand Up @@ -939,7 +938,6 @@ def test_LagInterfaceAddRemoveIpv4Address(self, dvs, testlog):
# remove port channel
self.remove_port_channel("PortChannel001")


def test_LagInterfaceSetMtu(self, dvs, testlog):
self.setup_db(dvs)

Expand Down Expand Up @@ -1116,7 +1114,6 @@ def test_LagInterfaceAddRemoveIpv6AddressWithVrf(self, dvs, testlog):
# remove port channel
self.remove_port_channel("PortChannel001")


def test_LagInterfaceAddRemoveIpv4AddressWithVrf(self, dvs, testlog):
self.setup_db(dvs)

Expand Down
7 changes: 6 additions & 1 deletion tests/test_nat.py
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,6 @@ def test_NatInterfaceZone(self, dvs, testlog):
break
assert zone == True


def test_AddNatStaticEntry(self, dvs, testlog):
# initialize
self.setup_db(dvs)
Expand Down Expand Up @@ -152,6 +151,7 @@ def test_DelNatStaticEntry(self, dvs, testlog):
key = tbl.getKeys()
assert key == ()

@pytest.mark.xfail(reason="vs image issue: Azure/sonic-sairedis#575")
def test_AddNaPtStaticEntry(self, dvs, testlog):
# initialize
self.setup_db(dvs)
Expand Down Expand Up @@ -193,6 +193,7 @@ def test_AddNaPtStaticEntry(self, dvs, testlog):
else:
assert False

@pytest.mark.xfail(reason="vs image issue: Azure/sonic-sairedis#575")
def test_DelNaPtStaticEntry(self, dvs, testlog):
# initialize
self.setup_db(dvs)
Expand All @@ -215,6 +216,7 @@ def test_DelNaPtStaticEntry(self, dvs, testlog):
key = tbl.getKeys()
assert key == ()

@pytest.mark.xfail(reason="vs image issue: Azure/sonic-sairedis#575")
def test_AddTwiceNatEntry(self, dvs, testlog):
# initialize
self.setup_db(dvs)
Expand Down Expand Up @@ -263,6 +265,7 @@ def test_AddTwiceNatEntry(self, dvs, testlog):
else:
assert False

@pytest.mark.xfail(reason="vs image issue: Azure/sonic-sairedis#575")
def test_DelTwiceNatStaticEntry(self, dvs, testlog):
# initialize
self.setup_db(dvs)
Expand All @@ -286,6 +289,7 @@ def test_DelTwiceNatStaticEntry(self, dvs, testlog):
key = tbl.getKeys()
assert key == ()

@pytest.mark.xfail(reason="vs image issue: Azure/sonic-sairedis#575")
def test_AddTwiceNaPtEntry(self, dvs, testlog):
# initialize
self.setup_db(dvs)
Expand Down Expand Up @@ -335,6 +339,7 @@ def test_AddTwiceNaPtEntry(self, dvs, testlog):
else:
assert False

@pytest.mark.xfail(reason="vs image issue: Azure/sonic-sairedis#575")
def test_DelTwiceNaPtStaticEntry(self, dvs, testlog):
# initialize
self.setup_db(dvs)
Expand Down
1 change: 1 addition & 0 deletions tests/test_port_dpb.py
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ def test_port_breakout_one(self, dvs):
'''
@pytest.mark.skip()
'''
@pytest.mark.xfail(reason="test stability issue: Azure/sonic-swss#1222")
def test_port_breakout_multiple(self, dvs):
dpb = DPB()
port_names = ["Ethernet0", "Ethernet12", "Ethernet64", "Ethernet112"]
Expand Down

0 comments on commit a1ff711

Please sign in to comment.