NextDevice Fix #268
Merged
NextDevice Fix #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch fixes an issue where the NextDevice function of the Executor was not being invoked prior to calling VolumeAttach. No value was being provided in the VolumeAttachOpts.NextDevice field. Now the executor should properly gather that information and provide it to the server in the event of an attach call.
Current coverage is 26.03% (diff: 0.00%)@@ master #268 diff @@
==========================================
Files 39 39
Lines 2420 2420
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 631 630 -1
- Misses 1721 1722 +1
Partials 68 68
|
proudh
added a commit
to proudh/libstorage
that referenced
this pull request
Sep 14, 2016
Courtesy of akutz's latest libstorage commit (PR thecodeteam#268) the device path of the next available device is now retrieved from the executor and not the storage driver. The device names for EBS are now /dev/xvd[f-p] as opposed to /dev/xvd[a-z], since EBS has suddenly begun to rebel against device names that are not of the pattern [f-p]. Also added some comments to the executor
proudh
added a commit
to proudh/libstorage
that referenced
this pull request
Sep 14, 2016
Courtesy of akutz's latest libstorage commit (PR thecodeteam#268) the device path of the next available device is now retrieved from the executor and not the storage driver. The device names for EBS are now /dev/xvd[f-p] as opposed to /dev/xvd[a-z], since EBS has suddenly begun to rebel against device names that are not of the pattern [f-p]. Also added some comments to the executor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes an issue where the NextDevice function of the Executor
was not being invoked prior to calling VolumeAttach. No value was being
provided in the VolumeAttachOpts.NextDevice field. Now the executor
should properly gather that information and provide it to the server in
the event of an attach call.