Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calling async fdir concurrently with different options behaves incorrectly #47

Closed
papb opened this issue Dec 15, 2020 · 0 comments · Fixed by #45
Closed

Calling async fdir concurrently with different options behaves incorrectly #47

papb opened this issue Dec 15, 2020 · 0 comments · Fixed by #45

Comments

@papb
Copy link
Contributor

papb commented Dec 15, 2020

The shared.js file contains some "dummy variables" that are later filled according to the options; however, if I make two (or more) calls concurrently, the second call may overwrite those variables while the first call did not finish yet, and then we get garbage results for the first call.
@papb papb mentioned this issue Dec 15, 2020
Merged
thecodrr pushed a commit that referenced this issue Dec 19, 2020
@papb
fix: #42, #46 and #47 (#45)
aa39f15 
* Fix concurrent async execution

* Fix #42

* Also pass `path` to exclude function

Closes #46

* Update documentation for `exclude`

* Update types for `exclude`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #42, #46 and #47
1 participant
@papb